[Openshift] Updates Hub pre-reconciler to manage Auth Url #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/M
tekton-robot
added
the
approved
|
The following is the coverage report on the affected files.
|
vdemeester
approved these changes
Jun 27, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: concaf, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Initially auth route was created in the pre-reconciler, but with latest Hub v1.8.0 release, based on the auth url, login is disabled and enabled Hence, if the api secret is not created by the user, tekton hub auth url status is set to empty else it is set to auth route Signed-off-by: Puneet Punamiya [email protected]
PuneetPunamiya
force-pushed
the
update-hub-pre-reconciler
branch
from
b263273 to
87969da
Compare
|
The following is the coverage report on the affected files.
|
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially auth route was created in the pre-reconciler,
but with latest Hub v1.8.0 release, based on the auth
url, login is disabled and enabled
Hence, if the api secret is not created by the user,
tekton hub auth url status is set to empty else it is
set to auth route
Signed-off-by: Puneet Punamiya [email protected]
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes