Adds container name to taskrun.status.steps

Recently while introducing some minor changes in steps status details, it broked some
functionality across CLI, Dashboard and other projects integration.
Maybe because those integration tries to extract some attributes related to the pod base on
TaskRun.Status fields i.e extracting the container name from step's name for
fetching the logs for TaskRun.Status.Steps.

In order to fix the issue, thi patch adds container name in step's status. So that
consumer of status api dont need figure internal details bsed on steps details.

Fixes #1027

pkg/apis/pipeline/v1alpha1/taskrun_types.go

@@ -169,6 +169,7 @@ func (tr *TaskRunStatus) SetCondition(newCond *apis.Condition) {
 type StepState struct {
 	corev1.ContainerState
 	Name string `json:"name,omitempty"`
+	Container string `json:"container,omitempty"`
 }
 
 // +genclient

pkg/status/taskrunpod.go

@@ -36,6 +36,7 @@ func UpdateStatusFromPod(taskRun *v1alpha1.TaskRun, pod *corev1.Pod, resourceLis
 			taskRun.Status.Steps = append(taskRun.Status.Steps, v1alpha1.StepState{
 				ContainerState: *s.State.DeepCopy(),
 				Name:           resources.TrimContainerNamePrefix(s.Name),
+				Container:      s.Name,
 			})
 		}
 	}
@@ -64,8 +65,8 @@ func updateCompletedTaskRun(taskRun *v1alpha1.TaskRun, pod *corev1.Pod) {
 		})
 	} else {
 		taskRun.Status.SetCondition(&apis.Condition{
-			Type:   apis.ConditionSucceeded,
-			Status: corev1.ConditionTrue,
+			Type:    apis.ConditionSucceeded,
+			Status:  corev1.ConditionTrue,
 			Reason:  ReasonSucceeded,
 			Message: "All Steps have completed executing",
 		})
@@ -78,9 +79,9 @@ func updateIncompleteTaskRun(taskRun *v1alpha1.TaskRun, pod *corev1.Pod) {
 	switch pod.Status.Phase {
 	case corev1.PodRunning:
 		taskRun.Status.SetCondition(&apis.Condition{
-			Type:   apis.ConditionSucceeded,
-			Status: corev1.ConditionUnknown,
-			Reason: ReasonBuilding,
+			Type:    apis.ConditionSucceeded,
+			Status:  corev1.ConditionUnknown,
+			Reason:  ReasonBuilding,
 			Message: "Not all Steps in the Task have finished executing",
 		})
 	case corev1.PodPending:

pkg/status/taskrunpod_test.go

@@ -78,6 +78,7 @@ func TestUpdateStatusFromPod(t *testing.T) {
 						ExitCode: 123,
 					}},
 				Name: "state-name",
+				Container: "step-state-name",
 			}},
 		},
 	}, {
@@ -107,6 +108,7 @@ func TestUpdateStatusFromPod(t *testing.T) {
 						ExitCode: 123,
 					}},
 				Name: "state-name",
+				Container: "step-state-name",
 			}},
 		},
 	}, {
@@ -132,6 +134,7 @@ func TestUpdateStatusFromPod(t *testing.T) {
 						ExitCode: 0,
 					}},
 				Name: "step-push",
+				Container: "step-step-push",
 			}},
 			// We don't actually care about the time, just that it's not nil
 			CompletionTime: &metav1.Time{Time: time.Now()},
@@ -156,6 +159,7 @@ func TestUpdateStatusFromPod(t *testing.T) {
 					Running: &corev1.ContainerStateRunning{},
 				},
 				Name: "running-step",
+				Container: "step-running-step",
 			}},
 		},
 	}, {
@@ -190,6 +194,7 @@ func TestUpdateStatusFromPod(t *testing.T) {
 						ExitCode: 123,
 					}},
 				Name: "failure",
+				Container: "step-failure",
 			}},
 			// We don't actually care about the time, just that it's not nil
 			CompletionTime: &metav1.Time{Time: time.Now()},
@@ -261,6 +266,7 @@ func TestUpdateStatusFromPod(t *testing.T) {
 					},
 				},
 				Name: "status-name",
+				Container: "step-status-name",
 			}},
 		},
 	}, {
@@ -364,6 +370,7 @@ func TestUpdateStatusFromPod(t *testing.T) {
 					Running: &corev1.ContainerStateRunning{},
 				},
 				Name: "running-step",
+				Container: "step-running-step",
 			}},
 		},
 	}} {