change LastTransitionTime to use metav1.Time

tektoncd · Sep 7, 2018 · 4c52cbf · 4c52cbf
1 parent bada2f6
commit 4c52cbf
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 8 deletions.
diff --git a/config/crds/pipeline_v1beta1_pipelinerun.yaml b/config/crds/pipeline_v1beta1_pipelinerun.yaml
@@ -28,6 +28,7 @@ spec:
               items:
                 properties:
                   lastTransitionTime:
+                    format: date-time
                     type: string
                   message:
                     type: string

diff --git a/config/crds/pipeline_v1beta1_taskrun.yaml b/config/crds/pipeline_v1beta1_taskrun.yaml
@@ -187,6 +187,7 @@ spec:
               items:
                 properties:
                   lastTransitionTime:
+                    format: date-time
                     type: string
                   message:
                     type: string

diff --git a/pkg/apis/pipeline/v1beta1/pipelinerun_types.go b/pkg/apis/pipeline/v1beta1/pipelinerun_types.go
@@ -105,9 +105,7 @@ type PipelineRunCondition struct {
 
 	Status corev1.ConditionStatus `json:"status"`
 
-	// TODO(bobcatfish): when I use `metav1.Time` here I can't figure out
-	// how to serialize :(
-	LastTransitionTime string `json:"lastTransitionTime"`
+	LastTransitionTime metav1.Time `json:"lastTransitionTime"`
 
 	Reason  string `json:"reason,omitempty"`
 	Message string `json:"message,omitempty"`

diff --git a/pkg/apis/pipeline/v1beta1/taskrun_types.go b/pkg/apis/pipeline/v1beta1/taskrun_types.go
@@ -92,9 +92,7 @@ type TaskRunCondition struct {
 
 	Status corev1.ConditionStatus `json:"status"`
 
-	// TODO(bobcatfish): when I use `metav1.Time` here I can't figure out
-	// how to serialize :(
-	LastTransitionTime string `json:"lastTransitionTime"`
+	LastTransitionTime metav1.Time `json:"lastTransitionTime"`
 
 	Reason  string `json:"reason,omitempty"`
 	Message string `json:"message,omitempty"`

diff --git a/pkg/apis/pipeline/v1beta1/zz_generated.deepcopy.go b/pkg/apis/pipeline/v1beta1/zz_generated.deepcopy.go