codegen using Go 1.19

The golang linting was upgraded in our CI to accomodate gofmt changes in Go 1.19. Please refer to the related PRs/issues: #5944 #5771 Signed-off-by: Yongxuan Zhang [email protected]
tektoncd · Feb 27, 2023 · 8ce47e5 · 8ce47e5
1 parent 5c41019
commit 8ce47e5
Show file tree

Hide file tree

Showing 32 changed files with 136 additions and 118 deletions.
diff --git a/cmd/entrypoint/runner.go b/cmd/entrypoint/runner.go
@@ -8,7 +8,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/cmd/git-init/main.go b/cmd/git-init/main.go
@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/cmd/imagedigestexporter/main.go b/cmd/imagedigestexporter/main.go
@@ -33,7 +33,9 @@ var (
 	terminationMessagePath = flag.String("terminationMessagePath", "/tekton/termination", "Location of file containing termination message")
 )
 
-/* The input of this go program will be a JSON string with all the output PipelineResources of type
+/*
+	The input of this go program will be a JSON string with all the output PipelineResources of type
+
 Image, which will include the path to where the index.json file will be located. The program will
 read the related index.json file(s) and log another JSON string including the name of the image resource
 and the digests.

diff --git a/cmd/pullrequest-init/main.go b/cmd/pullrequest-init/main.go
@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/docs/pipeline-api.md b/docs/pipeline-api.md
@@ -5960,9 +5960,9 @@ RunStatus
 <h3 id="tekton.dev/v1alpha1.VerificationPolicy">VerificationPolicy
 </h3>
 <div>
-<p>VerificationPolicy defines the Tekton resources and corresponding authorities to verify.
-The VerificationPolicy is used in trusted resources to store the public keys to verify
-Tekton resources.</p>
+<p>VerificationPolicy defines the rules to verify Tekton resources.
+VerificationPolicy can config the mapping from resources to a list of public
+keys, so when verifying the resources we can use the corresponding public keys.</p>
 </div>
 <table>
 <thead>
@@ -6028,9 +6028,9 @@ VerificationPolicySpec
 </em>
 </td>
 <td>
-<p>Resources defines the patterns of Resources names that should be subject to this policy.
-For example, we may want to apply this Policy only from a certain github repo.
-Then the ResourcesPattern should include the path. If using gitresolver, and we want to config keys from a certain git repo.
+<p>Resources defines the patterns of resources sources that should be subject to this policy.
+For example, we may want to apply this Policy from a certain GitHub repo.
+Then the ResourcesPattern should be valid regex. E.g. If using gitresolver, and we want to config keys from a certain git repo.
 <code>ResourcesPattern</code> can be <code>https://github.com/tektoncd/catalog.git</code>, we will use regex to filter out those resources.</p>
 </td>
 </tr>
@@ -6188,7 +6188,7 @@ the controller, but was unused as there is no controller for PipelineResource.</
 (<em>Appears on:</em><a href="#tekton.dev/v1alpha1.VerificationPolicySpec">VerificationPolicySpec</a>)
 </p>
 <div>
-<p>The Authority block defines the rules for validating signatures.</p>
+<p>The Authority block defines the keys for validating signatures.</p>
 </div>
 <table>
 <thead>
@@ -6219,7 +6219,7 @@ KeyRef
 </em>
 </td>
 <td>
-<p>Key defines the type of key to validate the resource.</p>
+<p>Key contains the public key to validate the resource.</p>
 </td>
 </tr>
 </tbody>
@@ -6295,6 +6295,14 @@ structs.</p>
 </tr>
 </tbody>
 </table>
+<h3 id="tekton.dev/v1alpha1.HashAlgorithm">HashAlgorithm
+(<code>string</code> alias)</h3>
+<p>
+(<em>Appears on:</em><a href="#tekton.dev/v1alpha1.KeyRef">KeyRef</a>)
+</p>
+<div>
+<p>HashAlgorithm defines the hash algorithm used for the public key</p>
+</div>
 <h3 id="tekton.dev/v1alpha1.KeyRef">KeyRef
 </h3>
 <p>
@@ -6341,7 +6349,9 @@ string
 <td>
 <code>hashAlgorithm</code><br/>
 <em>
-string
+<a href="#tekton.dev/v1alpha1.HashAlgorithm">
+HashAlgorithm
+</a>
 </em>
 </td>
 <td>
@@ -6376,8 +6386,8 @@ string
 </td>
 <td>
 <p>Pattern defines a resource pattern. Regex is created to filter resources based on <code>Pattern</code>
-Examples patterns:
-Github resource: <a href="https://github.com/tektoncd/catalog.git">https://github.com/tektoncd/catalog.git</a>, <a href="https://github.com/tektoncd/*">https://github.com/tektoncd/*</a>
+Example patterns:
+GitHub resource: <a href="https://github.com/tektoncd/catalog.git">https://github.com/tektoncd/catalog.git</a>, <a href="https://github.com/tektoncd/*">https://github.com/tektoncd/*</a>
 Bundle resource: gcr.io/tekton-releases/catalog/upstream/git-clone, gcr.io/tekton-releases/catalog/upstream/*
 Hub resource: <a href="https://artifacthub.io/*">https://artifacthub.io/*</a>,</p>
 </td>
@@ -6587,9 +6597,9 @@ Refer Go&rsquo;s ParseDuration documentation for expected format: <a href="https
 </em>
 </td>
 <td>
-<p>Resources defines the patterns of Resources names that should be subject to this policy.
-For example, we may want to apply this Policy only from a certain github repo.
-Then the ResourcesPattern should include the path. If using gitresolver, and we want to config keys from a certain git repo.
+<p>Resources defines the patterns of resources sources that should be subject to this policy.
+For example, we may want to apply this Policy from a certain GitHub repo.
+Then the ResourcesPattern should be valid regex. E.g. If using gitresolver, and we want to config keys from a certain git repo.
 <code>ResourcesPattern</code> can be <code>https://github.com/tektoncd/catalog.git</code>, we will use regex to filter out those resources.</p>
 </td>
 </tr>

diff --git a/pkg/apis/pipeline/pod/template.go b/pkg/apis/pipeline/pod/template.go
@@ -155,6 +155,7 @@ func (tpl *Template) ToAffinityAssistantTemplate() *AffinityAssistantTemplate {
 }
 
 // PodTemplate holds pod specific configuration
+//
 //nolint:revive
 type PodTemplate = Template
 

diff --git a/pkg/apis/pipeline/v1/container_types.go b/pkg/apis/pipeline/v1/container_types.go
@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/pkg/apis/pipeline/v1/taskrun_defaults_test.go b/pkg/apis/pipeline/v1/taskrun_defaults_test.go
@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/pkg/apis/pipeline/v1beta1/resource_types_validation.go b/pkg/apis/pipeline/v1beta1/resource_types_validation.go
@@ -73,9 +73,9 @@ func (tr *TaskRunResources) Validate(ctx context.Context) *apis.FieldError {
 }
 
 // validateTaskRunResources validates that
-//	1. resource is not declared more than once
-//	2. if both resource reference and resource spec is defined at the same time
-//	3. at least resource ref or resource spec is defined
+//  1. resource is not declared more than once
+//  2. if both resource reference and resource spec is defined at the same time
+//  3. at least resource ref or resource spec is defined
 func validateTaskRunResources(ctx context.Context, resources []TaskResourceBinding, path string) *apis.FieldError {
 	encountered := sets.NewString()
 	for _, r := range resources {

diff --git a/pkg/apis/pipeline/v1beta1/taskrun_defaults_test.go b/pkg/apis/pipeline/v1beta1/taskrun_defaults_test.go
@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/pkg/client/clientset/versioned/fake/register.go b/pkg/client/clientset/versioned/fake/register.go
diff --git a/pkg/client/clientset/versioned/scheme/register.go b/pkg/client/clientset/versioned/scheme/register.go
diff --git a/pkg/client/resolution/clientset/versioned/fake/register.go b/pkg/client/resolution/clientset/versioned/fake/register.go
diff --git a/pkg/client/resolution/clientset/versioned/scheme/register.go b/pkg/client/resolution/clientset/versioned/scheme/register.go
diff --git a/pkg/client/resource/clientset/versioned/fake/register.go b/pkg/client/resource/clientset/versioned/fake/register.go
diff --git a/pkg/client/resource/clientset/versioned/scheme/register.go b/pkg/client/resource/clientset/versioned/scheme/register.go
diff --git a/pkg/controller/filter.go b/pkg/controller/filter.go
@@ -34,10 +34,10 @@ import (
 // For example, a controller impl that wants to be notified of updates to Runs
 // which reference a Task with apiVersion "example.dev/v0" and kind "Example":
 //
-//     runinformer.Get(ctx).Informer().AddEventHandler(cache.FilteringResourceEventHandler{
-//       FilterFunc: FilterRunRef("example.dev/v0", "Example"),
-//       Handler:    controller.HandleAll(impl.Enqueue),
-//     })
+//	runinformer.Get(ctx).Informer().AddEventHandler(cache.FilteringResourceEventHandler{
+//	  FilterFunc: FilterRunRef("example.dev/v0", "Example"),
+//	  Handler:    controller.HandleAll(impl.Enqueue),
+//	})
 func FilterRunRef(apiVersion, kind string) func(interface{}) bool {
 	return func(obj interface{}) bool {
 		r, ok := obj.(*v1alpha1.Run)
@@ -67,10 +67,10 @@ func FilterRunRef(apiVersion, kind string) func(interface{}) bool {
 // For example, a controller impl that wants to be notified of updates to TaskRuns that are controlled by
 // a Run which references a custom task with apiVersion "example.dev/v0" and kind "Example":
 //
-//     taskruninformer.Get(ctx).Informer().AddEventHandler(cache.FilteringResourceEventHandler{
-//       FilterFunc: FilterOwnerRunRef("example.dev/v0", "Example"),
-//       Handler:    controller.HandleAll(impl.Enqueue),
-//     })
+//	taskruninformer.Get(ctx).Informer().AddEventHandler(cache.FilteringResourceEventHandler{
+//	  FilterFunc: FilterOwnerRunRef("example.dev/v0", "Example"),
+//	  Handler:    controller.HandleAll(impl.Enqueue),
+//	})
 func FilterOwnerRunRef(runLister listersalpha.RunLister, apiVersion, kind string) func(interface{}) bool {
 	return func(obj interface{}) bool {
 		object, ok := obj.(metav1.Object)
@@ -114,10 +114,10 @@ func FilterOwnerRunRef(runLister listersalpha.RunLister, apiVersion, kind string
 // For example, a controller impl that wants to be notified of updates to CustomRuns
 // which reference a Task with apiVersion "example.dev/v0" and kind "Example":
 //
-//     customruninformer.Get(ctx).Informer().AddEventHandler(cache.FilteringResourceEventHandler{
-//       FilterFunc: FilterCustomRunRef("example.dev/v0", "Example"),
-//       Handler:    controller.HandleAll(impl.Enqueue),
-//     })
+//	customruninformer.Get(ctx).Informer().AddEventHandler(cache.FilteringResourceEventHandler{
+//	  FilterFunc: FilterCustomRunRef("example.dev/v0", "Example"),
+//	  Handler:    controller.HandleAll(impl.Enqueue),
+//	})
 func FilterCustomRunRef(apiVersion, kind string) func(interface{}) bool {
 	return func(obj interface{}) bool {
 		r, ok := obj.(*v1beta1.CustomRun)
@@ -147,10 +147,10 @@ func FilterCustomRunRef(apiVersion, kind string) func(interface{}) bool {
 // For example, a controller impl that wants to be notified of updates to TaskRuns that are controlled by
 // a CustomRun which references a custom task with apiVersion "example.dev/v0" and kind "Example":
 //
-//     taskruninformer.Get(ctx).Informer().AddEventHandler(cache.FilteringResourceEventHandler{
-//       FilterFunc: FilterOwnerCustomRunRef("example.dev/v0", "Example"),
-//       Handler:    controller.HandleAll(impl.Enqueue),
-//     })
+//	taskruninformer.Get(ctx).Informer().AddEventHandler(cache.FilteringResourceEventHandler{
+//	  FilterFunc: FilterOwnerCustomRunRef("example.dev/v0", "Example"),
+//	  Handler:    controller.HandleAll(impl.Enqueue),
+//	})
 func FilterOwnerCustomRunRef(customRunLister listersbeta.CustomRunLister, apiVersion, kind string) func(interface{}) bool {
 	return func(obj interface{}) bool {
 		object, ok := obj.(metav1.Object)

diff --git a/pkg/internal/affinityassistant/transformer_test.go b/pkg/internal/affinityassistant/transformer_test.go
@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/pkg/internal/computeresources/compare/compare.go b/pkg/internal/computeresources/compare/compare.go
@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/pkg/internal/computeresources/limitrange/limitrange_test.go b/pkg/internal/computeresources/limitrange/limitrange_test.go
@@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+	http://www.apache.org/licenses/LICENSE-2.0
 
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,
-Original file line number
+Diff line change
@@ Expand Up @@
     }
     // PodTemplate holds pod specific configuration
+    //
     //nolint:revive
     type PodTemplate = Template
@@ Expand Down @@