Fix flaky test by sorting slices

TestGetVarSubstitutionExpressionsForPipelineResult was flaky since the expected test output was in a fixed order while the function under test was iterating through a map where order is not guaranteed. This commit fixes it by sorting the inputs to cmp.Diff Signed-off-by: Dibyo Mukherjee <[email protected]>
tektoncd · Jul 20, 2022 · a4f9216 · a4f9216
1 parent 94055d9
commit a4f9216
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/pkg/apis/pipeline/v1beta1/resultref_test.go b/pkg/apis/pipeline/v1beta1/resultref_test.go
@@ -754,10 +754,13 @@ func TestGetVarSubstitutionExpressionsForPipelineResult(t *testing.T) {
 		want: []string{"tasks.task1.results.result1", "tasks.task2.results.result2", "tasks.task3.results.result3"},
 	},
 	}
+	var sortStrings = func(x, y string) bool {
+		return x < y
+	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			get, _ := v1beta1.GetVarSubstitutionExpressionsForPipelineResult(tt.result)
-			if d := cmp.Diff(tt.want, get); d != "" {
+			if d := cmp.Diff(tt.want, get, cmpopts.SortSlices(sortStrings)); d != "" {
 				t.Error(diff.PrintWantGot(d))
 			}
 		})