Skip to content

Commit

Permalink
TEP-0075: Implement object var replacement on task&taskrun level
Browse files Browse the repository at this point in the history
Implement variable replacement for object's individual attributes
on task&taskrun level.

[According to TEP-0075, when providing values for strings, Task and
Pipeline authors can access individual attributes of an object param;
they cannot access the object as whole.]
  • Loading branch information
chuangw6 committed May 24, 2022
1 parent 4a93b62 commit bb88540
Show file tree
Hide file tree
Showing 2 changed files with 336 additions and 4 deletions.
20 changes: 16 additions & 4 deletions pkg/reconciler/taskrun/resources/apply.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,30 +49,42 @@ func ApplyParameters(spec *v1beta1.TaskSpec, tr *v1beta1.TaskRun, defaults ...v1
"inputs.params.%s",
}

objectIndividualVariablePattern := "params.%s.%s"

// Set all the default stringReplacements
for _, p := range defaults {
if p.Default != nil {
if p.Default.Type == v1beta1.ParamTypeString {
switch p.Default.Type {
case v1beta1.ParamTypeString:
for _, pattern := range patterns {
stringReplacements[fmt.Sprintf(pattern, p.Name)] = p.Default.StringVal
}
} else {
case v1beta1.ParamTypeArray:
for _, pattern := range patterns {
arrayReplacements[fmt.Sprintf(pattern, p.Name)] = p.Default.ArrayVal
}
default:
for k, v := range p.Default.ObjectVal {
stringReplacements[fmt.Sprintf(objectIndividualVariablePattern, p.Name, k)] = v
}
}
}
}
// Set and overwrite params with the ones from the TaskRun
for _, p := range tr.Spec.Params {
if p.Value.Type == v1beta1.ParamTypeString {
switch p.Value.Type {
case v1beta1.ParamTypeString:
for _, pattern := range patterns {
stringReplacements[fmt.Sprintf(pattern, p.Name)] = p.Value.StringVal
}
} else {
case v1beta1.ParamTypeArray:
for _, pattern := range patterns {
arrayReplacements[fmt.Sprintf(pattern, p.Name)] = p.Value.ArrayVal
}
default:
for k, v := range p.Value.ObjectVal {
stringReplacements[fmt.Sprintf(objectIndividualVariablePattern, p.Name, k)] = v
}
}
}
return ApplyReplacements(spec, stringReplacements, arrayReplacements)
Expand Down
Loading

0 comments on commit bb88540

Please sign in to comment.