Add comments

tektoncd · Jan 21, 2020 · d66bb0d · d66bb0d
1 parent f73554b
commit d66bb0d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/cmd/entrypoint/main.go b/cmd/entrypoint/main.go
@@ -54,6 +54,8 @@ func main() {
 		PostWriter:      &realPostWriter{},
 		Results:         strings.Split(*results, ","),
 	}
+	// strings.Split(..) with an empty string returns an array that contains one element, an empty string.
+	// The result folder should only be created if there are actual results to defined for the entrypoint.
 	if len(e.Results) >= 1 && e.Results[0] != "" {
 		if err := os.MkdirAll(pipeline.DefaultResultPath, 0755); err != nil {
 			log.Fatalf("Error creating the results directory: %v", err)

diff --git a/pkg/entrypoint/entrypointer.go b/pkg/entrypoint/entrypointer.go
@@ -107,6 +107,8 @@ func (e Entrypointer) Go() error {
 	// Write the post file *no matter what*
 	e.WritePostFile(e.PostFile, err)
 
+	// strings.Split(..) with an empty string returns an array that contains one element, an empty string.
+	// This creates an error when trying to open the result folder as a file.
 	if len(e.Results) >= 1 && e.Results[0] != "" {
 		if err := e.readResultsFromDisk(); err != nil {
 			logger.Fatalf("Error while handling results: %s", err)