Add checklist item for release notes ✅

While looking into #2816 we realized that #2501 had indicated that this will require users to delete their Deployments but since the note wasn't in a release notes block it was missed (by me!) Adding this to the checklist might help contributors and reviewers be more aware. We also found that prow has a "release notes" plugin that might check this for us on PRs if we turn it on: https://github.com/kubernetes/test-infra/blob/128455dfd8003346afcdffa111d2298587f6fbf0/prow/plugins/releasenote/releasenote.go Co-authored-by: Sharon Jerop Kipruto <[email protected]>
tektoncd · Jun 16, 2020 · d70aa47 · d70aa47
1 parent 5656c20
commit d70aa47
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
@@ -13,6 +13,7 @@ review them:
 - [ ] Includes [tests](https://github.com/tektoncd/community/blob/master/standards.md#principles) (if functionality changed/added)
 - [ ] Includes [docs](https://github.com/tektoncd/community/blob/master/standards.md#principles) (if user facing)
 - [ ] Commit messages follow [commit message best practices](https://github.com/tektoncd/community/blob/master/standards.md#commit-messages)
+- [ ] Release notes block has been filled in or deleted (only if no user facing changes)
 
 _See [the contribution guide](https://github.com/tektoncd/pipeline/blob/master/CONTRIBUTING.md) for more details._
 
@@ -34,5 +35,6 @@ Examples of user facing changes:
 - API changes
 - Bug fixes
 - Any changes in behavior
+- Changes requiring upgrade notices or deprecation warnings
 
 ```