Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TaskRun Validation - Controller Side #188

Closed
bobcatfish opened this issue Oct 25, 2018 · 0 comments
Closed

TaskRun Validation - Controller Side #188

bobcatfish opened this issue Oct 25, 2018 · 0 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@bobcatfish
Copy link
Collaborator

Expected Behavior

TaskRun CRDs can be validated semantically. This includes:

  1. All referenced CRDs (Tasks, Resources, etc.) exist
  2. All required inputs for the Task are bound
  3. All required outputs for the Task are bound
  4. All required parameters for the Task are provided

Actual Behavior

Validation is superficial only. No referenced objects are dereferenced in the webhook.

Additional Info

#162 is related work for the Pipeline.
@bobcatfish bobcatfish added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Oct 25, 2018
@bobcatfish bobcatfish mentioned this issue Oct 25, 2018
Closed
@aaron-prindle aaron-prindle mentioned this issue Oct 25, 2018
Merged
5 tasks
@aaron-prindle aaron-prindle self-assigned this Oct 30, 2018
@aaron-prindle aaron-prindle mentioned this issue Oct 31, 2018
Merged
knative-prow-robot pushed a commit that referenced this issue Nov 1, 2018
@aaron-prindle @knative-prow-robot
TaskRun Validation - Controller Side
9ae0688 
What is the problem being solved?
Fixes #188, TaskRun Validation - Controller Side.  This PR adds additional TaskRun validation to the TaskRun controller which checks that referenced Params and Resources exist and that they are bound properly from the Task.

Why is this the best approach?
This approach follows the style and convention for a similar issues, #162, PipelineRun validation.

What other approaches did you consider?
N/A

What side effects will this approach have?
It is possible that some demo/sample yaml which use to execute will no longer work as we have this additional validation.

What future work remains to be done?
For the TaskRun controller, I believe that this validation is sufficient.  In the future we should extend validation to all of our primitive types, especially PipelineResource.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bobcatfish @aaron-prindle