-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate 'pipelinerun.successful' cloudevent #3336
Comments
Hello @wwu-cx, thanks for this bug report. |
afrittoli
added a commit
to afrittoli/pipeline
that referenced
this issue
Oct 7, 2020
Change the logic for cloud events to be sent only if a change is detected in the condition, specifically in state, message or reason. Fixes tektoncd#3336 Signed-off-by: Andrea Frittoli <[email protected]>
4 tasks
tekton-robot
pushed a commit
that referenced
this issue
Oct 7, 2020
Change the logic for cloud events to be sent only if a change is detected in the condition, specifically in state, message or reason. Fixes #3336 Signed-off-by: Andrea Frittoli <[email protected]>
vdemeester
pushed a commit
to vdemeester/tektoncd-pipeline
that referenced
this issue
Oct 12, 2020
Change the logic for cloud events to be sent only if a change is detected in the condition, specifically in state, message or reason. Fixes tektoncd#3336 Signed-off-by: Andrea Frittoli <[email protected]> (cherry picked from commit 3d35b87) Signed-off-by: Vincent Demeester <[email protected]>
4 tasks
tekton-robot
pushed a commit
that referenced
this issue
Oct 12, 2020
Change the logic for cloud events to be sent only if a change is detected in the condition, specifically in state, message or reason. Fixes #3336 Signed-off-by: Andrea Frittoli <[email protected]> (cherry picked from commit 3d35b87) Signed-off-by: Vincent Demeester <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
A single 'dev.tekton.event.pipelinerun.successful.v1' event after a successfull pipelinerun.
Actual Behavior
Two 'dev.tekton.event.pipelinerun.successful.v1' events with different id's and different timestamps referencing the same run:
First:
"ce-type": "dev.tekton.event.pipelinerun.successful.v1"
"ce-time": "2020-10-06T05:19:26.898238287Z",
"ce-subject": "tekton-builds-wwu-p2v8b-r-7bgc4",
"ce-id": "c7a26faa-a825-4a0f-8c2d-9ce192a9a5b8",
"ce-source": "/apis/tekton.dev/v1beta1/namespaces/tekton-builds/pipelineruns/tekton-builds-wwu-p2v8b-r-7bgc4",
Second:
"ce-type": "dev.tekton.event.pipelinerun.successful.v1",
"ce-time": "2020-10-06T05:19:26.952135384Z",
"ce-subject": "tekton-builds-wwu-p2v8b-r-7bgc4",
"ce-id": "fe652d4a-53fc-4bd7-9bbc-cc41f6953f86",
"ce-source": "/apis/tekton.dev/v1beta1/namespaces/tekton-builds/pipelineruns/tekton-builds-wwu-p2v8b-r-7bgc4",
Steps to Reproduce the Problem
Additional Info
The text was updated successfully, but these errors were encountered: