Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make validateObjectKeys() Public for Tekton Chains to Use #5072

Closed
ywluogg opened this issue Jul 4, 2022 · 3 comments
Closed

Make validateObjectKeys() Public for Tekton Chains to Use #5072

ywluogg opened this issue Jul 4, 2022 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@ywluogg
Copy link
Contributor

ywluogg commented Jul 4, 2022

Feature request

validateObjectKeys is validating properties against a ArrayOrSting, which is needed in Tekton Chains. To avoid code duplication, this worths becoming a public function

Use case

See above
@ywluogg ywluogg added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 4, 2022
@ywluogg
Copy link
Contributor Author

ywluogg commented Jul 4, 2022 •
edited
Loading

/assign @chuangw6

@ywluogg
Copy link
Contributor Author

ywluogg commented Jul 4, 2022

Hi Chuang, I'm wondering if you have time to make the function public? Thanks

chuangw6 added a commit to chuangw6/pipeline that referenced this issue Jul 4, 2022
@chuangw6
Export ValidateObjectKeys function
9c15885 
Export this function for chains to use it.
tektoncd#5072
@chuangw6 chuangw6 mentioned this issue Jul 4, 2022
Merged
5 tasks
@chuangw6
Copy link
Member

chuangw6 commented Jul 5, 2022

sg! done #5073 !

tekton-robot pushed a commit that referenced this issue Jul 5, 2022
@chuangw6 @tekton-robot
Export ValidateObjectKeys function
6876520 
Export this function for chains to use it.
#5072
@ywluogg ywluogg closed this as completed Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chuangw6 @ywluogg