Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capturing PipelineResources in v1 Objects for backwards compatibility #7105

Open
chitrangpatel opened this issue Sep 12, 2023 · 2 comments
Open

Capturing PipelineResources in v1 Objects for backwards compatibility #7105

chitrangpatel opened this issue Sep 12, 2023 · 2 comments
Assignees
@chitrangpatel
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@chitrangpatel
Copy link
Contributor

chitrangpatel commented Sep 12, 2023 •
edited
Loading

Currently, Tekton Chains watches v1beta1 object and wants to migrate to watching v1 as well. However, there are deprecated fields like TaskRunResources and ResourcesResult that need to be converted to v1 and back so that we can apply the necessary formatting.

Expected Behavior

If I take v1beta1 with TaskRunResources and convert to v1, I expected to see it in Annotations.

Actual Behavior

However, if I print the annotations of the converted object, it's an empty map and all information regarding TaskRunResources and ResourcesResults is lost.

My guess is that while this const is defined, we are not actually populating it in the Annotations like we do with cloud events

When we restored Pipeline Resources, we probably forgot to restore the conversion functions (cc @lbernick ).

/kind bug
@chitrangpatel chitrangpatel added the kind/bug Categorizes issue or PR as related to a bug. label Sep 12, 2023
@chitrangpatel
Copy link
Contributor Author

cc @wlynch @chuangw6 @lcarva

@chitrangpatel
Copy link
Contributor Author

/assign

@chitrangpatel chitrangpatel changed the title Capturing PipelineResources in v1 Objects for backwards compatibility Capturing TaskRunResources and ResourcesResult in v1 Objects for backwards compatibility Sep 12, 2023
@chitrangpatel chitrangpatel changed the title Capturing TaskRunResources and ResourcesResult in v1 Objects for backwards compatibility Capturing TaskRunResources and ResourcesResult in v1 Objects for backwards compatibility Sep 12, 2023
@chitrangpatel chitrangpatel changed the title Capturing TaskRunResources and ResourcesResult in v1 Objects for backwards compatibility Capturing PipelineResources in v1 Objects for backwards compatibility Sep 12, 2023
chitrangpatel added a commit to chitrangpatel/pipeline that referenced this issue Sep 13, 2023
@chitrangpatel
Recover Conversion Functions from Pipeline Resources
921eac2 
When we reverted removal of `PipelineResources` [related fields](tektoncd#6436),
we did not recover the conversion functions. As a result, when migrating
Tekton Chains to watch `v1` objects, we run into Issue
tektoncd#7105.

This PR recovers the conversion functions so that we can continue to
convert PipelineResources related fields.
chitrangpatel added a commit to chitrangpatel/pipeline that referenced this issue Sep 13, 2023
@chitrangpatel
Recover Conversion Functions from Pipeline Resources
88d63ea 
When we reverted removal of `PipelineResources` [related fields](tektoncd#6436),
we did not recover the conversion functions. As a result, when migrating
Tekton Chains to watch `v1` objects, we run into Issue
tektoncd#7105.

This PR recovers the conversion functions so that we can continue to
convert PipelineResources related fields.
@chitrangpatel chitrangpatel mentioned this issue Sep 13, 2023
Merged
7 tasks
tekton-robot pushed a commit that referenced this issue Sep 25, 2023
@chitrangpatel @tekton-robot
Recover Conversion Functions from Pipeline Resources
0e1b1a3 
When we reverted removal of `PipelineResources` [related fields](#6436),
we did not recover the conversion functions. As a result, when migrating
Tekton Chains to watch `v1` objects, we run into Issue
#7105.

This PR recovers the conversion functions so that we can continue to
convert PipelineResources related fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chitrangpatel chitrangpatel

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chitrangpatel