Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Steps with workingDir refuse to start because the directory does not exist on pod startup #725

Closed
dicarlo2 opened this issue Apr 4, 2019 · 2 comments · Fixed by #843
Closed

Steps with workingDir refuse to start because the directory does not exist on pod startup #725

dicarlo2 opened this issue Apr 4, 2019 · 2 comments · Fixed by #843
Assignees
@dicarlo2
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@dicarlo2
Copy link
Contributor

dicarlo2 commented Apr 4, 2019

Expected Behavior

We can set the workingDir to a subdirectory of the workspace directory (e.g. the one we plan to populate with a git repository).

Actual Behavior

Pods fail because the containers can't chdir into a directory that does not exist. This is likely a bug due to the move from init containers (where the directory would have existed since they start in order).

Steps to Reproduce the Problem

Create a task/taskrun with

  1. a git input with targetPath "foo"
  2. a step with workingDir "workspace/foo"

Additional Info
dicarlo2 added a commit to dicarlo2/pipeline that referenced this issue Apr 4, 2019
@dicarlo2
Initialize working dirs inside workspace dir
f1dfc43 
In order to allow steps to define workingDirs that are subdirectories of the workspace directory we need to make sure they have been created first since they will not exist on startup.

Fixes tektoncd#725
@dicarlo2 dicarlo2 mentioned this issue Apr 4, 2019
Closed
3 tasks
@vdemeester vdemeester added kind/bug Categorizes issue or PR as related to a bug. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Apr 5, 2019
@vdemeester
Copy link
Member

/assign @dicarlo2

@bobcatfish
Copy link
Collaborator

Ah nice one @dicarlo2 - I ran into this while dogfooding as well but wrote it off as moby/moby#32708 and gave up on it (i think that's the same problem!)

Thanks for being proactive and pushing us to actually fix this XD

dicarlo2 added a commit to dicarlo2/pipeline that referenced this issue Apr 23, 2019
@dicarlo2
Initialize working dirs inside workspace dir
42b6b32 
In order to allow steps to define workingDirs that are subdirectories of the workspace directory we need to make sure they have been created first since they will not exist on startup.

Fixes tektoncd#725
dicarlo2 added a commit to dicarlo2/pipeline that referenced this issue Apr 23, 2019
@dicarlo2
Initialize working dirs inside workspace dir
34db1a7 
In order to allow steps to define workingDirs that are subdirectories of the workspace directory we need to make sure they have been created first since they will not exist on startup.

Fixes tektoncd#725
dicarlo2 added a commit to dicarlo2/pipeline that referenced this issue May 3, 2019
@dicarlo2
Initialize working dirs inside workspace dir
871c87f 
In order to allow steps to define workingDirs that are subdirectories of the workspace directory we need to make sure they have been created first since they will not exist on startup.

Fixes tektoncd#725
dicarlo2 added a commit to dicarlo2/pipeline that referenced this issue May 3, 2019
@dicarlo2
Initialize working dirs inside workspace dir
2f3691e 
In order to allow steps to define workingDirs that are subdirectories of the workspace directory we need to make sure they have been created first since they will not exist on startup.

Fixes tektoncd#725
@jstrachan jstrachan mentioned this issue May 8, 2019
Closed
3 tasks
tekton-robot pushed a commit that referenced this issue May 8, 2019
@dicarlo2 @tekton-robot
Initialize working dirs inside workspace dir
b81e22d 
In order to allow steps to define workingDirs that are subdirectories of the workspace directory we need to make sure they have been created first since they will not exist on startup.

Fixes #725
@abayer abayer mentioned this issue May 8, 2019
Merged
3 tasks
wlynch pushed a commit to wlynch/pipeline that referenced this issue May 20, 2019
@dicarlo2 @wlynch
Initialize working dirs inside workspace dir
6a27266 
In order to allow steps to define workingDirs that are subdirectories of the workspace directory we need to make sure they have been created first since they will not exist on startup.

Fixes tektoncd#725
@bobcatfish bobcatfish mentioned this issue Sep 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dicarlo2 dicarlo2

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
3 participants
@vdemeester @bobcatfish @dicarlo2