Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ClusterTask to webhook (for validation) #1082

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Add ClusterTask to webhook (for validation) #1082

merged 1 commit into from
Jul 16, 2019

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Jul 16, 2019 •
edited
Loading

Changes

We are not validating nor mutating ClusterTask as we do for
other objects. This fixes that by adding it to what the webhook watches.

Will be cherry-picked in v0.5.2 👼

/cc @bobcatfish

Signed-off-by: Vincent Demeester [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Release Notes

Make sure ClusterTask are validated by the webhook (as are other resources)

@vdemeester
Add ClusterTask to webhook (for validation)
3ce6ec9 
We are not validating **nor** mutating `ClusterTask` as we do for
other objects. This fixes that by adding it to what the webhook watches.

Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot tekton-robot requested a review from bobcatfish July 16, 2019 08:00
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Jul 16, 2019
@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 16, 2019
@vdemeester vdemeester added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jul 16, 2019
@vdemeester vdemeester added this to the Pipelines 0.5 🐱 milestone Jul 16, 2019
bobcatfish
bobcatfish reviewed Jul 16, 2019
View reviewed changes
Copy link
Collaborator

@bobcatfish bobcatfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I am a bit hesitant to put this in the 0.5 release - it feels kinda like a new feature and since that release has been a bit unstable I feel like it's good to minimize what we're adding (e.g. what if there was a bug in our validation and suddenly we started panicking on clustertask validation)

I'm happy to go with whatever you prefer tho @vdemeester !!

/lgtm
/meow space

pkg/apis/pipeline/v1alpha1/cluster_task_types.go

func (t *ClusterTask) Copy() TaskInterface {
return t.DeepCopy()
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did these get moved for a functional reason or just for code organization?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobcatfish just for code organization 👼

@tekton-robot
Copy link
Collaborator

@bobcatfish: cat image

In response to this:

Looks good!

I am a bit hesitant to put this in the 0.5 release - it feels kinda like a new feature and since that release has been a bit unstable I feel like it's good to minimize what we're adding (e.g. what if there was a bug in our validation and suddenly we started panicking on clustertask validation)

I'm happy to go with whatever you prefer tho @vdemeester !!

/lgtm
/meow space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2019
@tekton-robot tekton-robot merged commit 658c963 into tektoncd:master Jul 16, 2019
@vdemeester vdemeester deleted the clustertask-webhook branch July 16, 2019 12:42
@vdemeester
Copy link
Member Author

I am a bit hesitant to put this in the 0.5 release - it feels kinda like a new feature and since that release has been a bit unstable I feel like it's good to minimize what we're adding (e.g. what if there was a bug in our validation and suddenly we started panicking on clustertask validation)

Fair 😉 Let's add that to the 0.6.x milestone then 😉

@vdemeester vdemeester removed the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobcatfish bobcatfish bobcatfish left review comments

Assignees

@bobcatfish bobcatfish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines 0.6 🐱
Development

Successfully merging this pull request may close these issues.
4 participants
@vdemeester @tekton-robot @bobcatfish @googlebot