Minor docs fixes and extra templating test #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tekton-robot
added
the
size/M
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, dlorenc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
ghost
reviewed
Aug 5, 2019
| @@ -57,7 +57,7 @@ only start with alpha characters and `_`. For example, `fooIs-Bar_` is a valid | |||
| parameter name, `barIsBa$` or `0banana` are not. | |||
|
|
|||
| Each declared parameter has a type field, assumed to be string if not provided by the user. | |||
| The other possible type is array — useful,checking a pushed branch name doesn't match any of | |||
| The other possible type is array — useful, checking a pushed branch name doesn't match any of | |||
There was a problem hiding this comment.
The comma confuses the reading a bit here I think. Suggest small rewording:
The other possible type is array - useful for checking whether a pushed branch matches any of ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR has some minor docs changes and an additional unit test that addresses PR feedback from #1143 and #1133 :