-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct pod watching in Taskrun controller #1269
Conversation
Should use `cache.FilteringResourceEventHandler` rather than `cache.ResourceEventHandlerFuncs`. The `pod` with incorrect owner will not go into the queue.
/assign @imjasonh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this.
I started reading about informers but I think I need a bit more background to fully understand this.
One thing I noticed looking at controller logs is that I often get errors about resources that aren't supposed to be in the taskrun controller queue to begin with, so perhaps this is about fixing that?
Example:
{"level":"info","logger":"controller.taskrun-controller","caller":"taskrun/taskrun.go:94","msg":"task run \"istio-system/istio-telemetry-78f76f9d6\" in work queue no longer exists","knative.dev/controller":"taskrun-controller"}
@afrittoli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, vincent-pli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Should use
cache.FilteringResourceEventHandler
rather thancache.ResourceEventHandlerFuncs
.The
pod
with incorrect owner will not go into the queue.Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task and TaskRun to build and release this image