Fix bug in entrypoint lookup for steps by digest #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tekton-robot
added
the
size/XXL
|
cc @mattmoor |
imjasonh
force-pushed
the
fix-entrypoint-lookup
branch
2 times, most recently
from
6ca1635 to
69b639b
Compare
Before this change, any resolved digests would be simply appended to the input image name, which would result in invalid duplicate digests when the input was specified by digest. This change uses ref.Context() instead, which omits the digest (or tag), and appends the resolved digest to the end of that. This also slightly refactors entrypoint_lookup_impl.go to make it slightly easier to test, and adds a simple unit test for this specific error condition. More tests will be included in future changes.
imjasonh
force-pushed
the
fix-entrypoint-lookup
branch
from
69b639b to
d0dfa77
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlorenc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
FWIW, I confirmed that this resolved the issue I hit. thanks for the quick fix @imjasonh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, any resolved digests would be simply appended to the
input image name, which would result in invalid duplicate digests when
the input was specified by digest.
This change uses
ref.Context()instead, which omits the digest (or tag),and appends the resolved digest to the end of that.
This also slightly refactors entrypoint_lookup_impl.go to make it
slightly easier to test, and adds a simple unit test for this specific
error condition.
More tests will be included in future changes.
Fixes #1674
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes