Move image data extraction into entrypoint_lookup.go #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Image data extraction (pulling entrypoint and digest) isn't specific to the real implementation of fetching image metadata using K8s imagePullSecrets, so having this only implemented and tested in that context didn't make sense. This change also adds cache population (Set) moved into the EntrypointCache interface, rather than having it be a side effect of Get. This means that entrypoint_lookup.go must call cache.Set after it extracts digest. The result is a cleaner separation of concerns between generic entrypoint lookup logic and K8s-specific implementation, which is now more narrowly scoped.
googlebot
added
the
cla: yes
tekton-robot
added
the
size/L
|
/lgtm |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image data extraction (pulling entrypoint and digest) isn't specific to
the real implementation of fetching image metadata using K8s
imagePullSecrets, so having this only implemented and tested in that
context didn't make sense.
This change also adds cache population (
Set) moved into theEntrypointCacheinterface, rather than having it be a side effect ofGet. This means thatentrypoint_lookup.gomust callcache.Setafter itextracts digest.
The result is a cleaner separation of concerns between generic
entrypoint lookup logic and K8s-specific implementation, which is now
more narrowly scoped.
More iteration on #1605
Ideally this separation and testing would have helped catch #1674
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.