Cleanup the prow nightly release task and pipeline #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tekton-robot
added
the
size/L
|
🎉 |
afrittoli
force-pushed
the
publish_task
branch
from
d3827d9 to
7759aed
Compare
afrittoli
added a commit
to afrittoli/plumbing
that referenced
this pull request
Dec 10, 2019
Use the updated pipeline nightly release. See tektoncd/pipeline#1718 Use a cloudEvent resource dedicated to nightly builds to avoid conflicts with full releases.
2 tasks
afrittoli
added a commit
to afrittoli/plumbing
that referenced
this pull request
Dec 10, 2019
Use the updated pipeline nightly release. See tektoncd/pipeline#1718 Use a cloudEvent resource dedicated to nightly builds to avoid conflicts with full releases. Remove the ko image, which is now built nightly.
tekton-robot
pushed a commit
to tektoncd/plumbing
that referenced
this pull request
Dec 10, 2019
Use the updated pipeline nightly release. See tektoncd/pipeline#1718 Use a cloudEvent resource dedicated to nightly builds to avoid conflicts with full releases. Remove the ko image, which is now built nightly.
afrittoli
force-pushed
the
publish_task
branch
3 times, most recently
from
1043804 to
8723c71
Compare
3 tasks
Nightly release do not use prow anymore, so we don't need a custom publish task anymore. We still use two separate pipelines, one for full releases and one for nightly releases. Fix a typo in the publish task and update docs to match the current release process.
afrittoli
force-pushed
the
publish_task
branch
from
8723c71 to
30b598a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test pull-tekton-pipeline-integration-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Nightly release do not use prow anymore, so we don't need a custom
publish task anymore. We still use two separate pipelines, one
for full releases and one for nightly releases.
Fix a typo in the publish task.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes