Issue 1862: Gitlab status upload fails with missing commit error #1863
Conversation
googlebot
added
the
cla: yes
tekton-robot
added
the
size/M
|
Notes:
|
There was a problem hiding this comment.
Yeah the underlying issue is that the go-scm library isn't populating this value - https://github.com/jenkins-x/go-scm/blob/master/scm/driver/gitlab/pr.go#L175-L195
I can take an AI to add this.
This is something that probably makes sense to do regard less.
|
This PR adds the preloading of data into the resource.PullRequest used in the FromDisk() method. If the pr.json file has been copied into the ouput directory, it is unmarshalled into the resource prior to subsequent updates from other files on disk, avoiding overwiting the r.PR.Sha with a null value from head.json (should that situation occur).
|
/lgtm |
|
/test pull-tekton-pipeline-integration-tests |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
issue #1862 |
Changes
This PR adds the preloading of data into the resource.PullRequest
used in the FromDisk() method. If the pr.json file has been copied
into the ouput directory, it is unmarshalled into the resource prior
to subsequent updates from other files on disk, avoiding overwiting
the r.PR.Sha with a null value from head.json (should that situation
occur).
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes