Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Porting go e2e test to v1beta1 #2252

Merged
merged 3 commits into from
Mar 24, 2020
Merged

Porting go e2e test to v1beta1 #2252

merged 3 commits into from
Mar 24, 2020

Conversation

vdemeester
Copy link
Member

Changes

Migrate e2e go tests to use v1beta1 and moving the current ones to their own package (test/v1alpha1).

It also has small refactoring 🙃

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2020
@tekton-robot tekton-robot requested review from bobcatfish and a user March 19, 2020 12:53
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Mar 19, 2020
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 19, 2020
@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go 95.2% 90.9% -4.3
pkg/apis/pipeline/v1beta1/param_types.go 34.0% 31.6% -2.4
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 90.0% 87.1% -2.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go 95.2% 90.9% -4.3
pkg/apis/pipeline/v1beta1/param_types.go 34.0% 31.6% -2.4
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 90.0% 87.1% -2.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go 95.2% 90.9% -4.3
pkg/apis/pipeline/v1beta1/param_types.go 34.0% 31.6% -2.4
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 90.0% 87.1% -2.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go 95.2% 90.9% -4.3
pkg/apis/pipeline/v1beta1/param_types.go 34.0% 31.6% -2.4
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 90.0% 87.1% -2.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go 95.2% 90.9% -4.3
pkg/apis/pipeline/v1beta1/param_types.go 34.0% 31.6% -2.4
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 90.0% 87.1% -2.9

@vdemeester
Copy link
Member Author

Yay e2e are green, I'll finish the rest tomorrow (and it will automatically fix build-tests)

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go 95.2% 90.9% -4.3
pkg/apis/pipeline/v1beta1/param_types.go 34.0% 31.6% -2.4
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 90.0% 87.1% -2.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go 95.2% 90.9% -4.3
pkg/apis/pipeline/v1beta1/param_types.go 34.0% 31.6% -2.4
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 90.0% 87.1% -2.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go 95.2% 90.9% -4.3
pkg/apis/pipeline/v1beta1/param_types.go 34.0% 31.6% -2.4
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 90.0% 87.1% -2.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go 95.2% 90.9% -4.3
pkg/apis/pipeline/v1beta1/param_types.go 34.0% 31.6% -2.4
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 90.0% 87.1% -2.9

@vdemeester vdemeester changed the title wip: porting go e2e test to v1beta1 Porting go e2e test to v1beta1 Mar 20, 2020
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2020
@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go 95.2% 90.9% -4.3
pkg/apis/pipeline/v1beta1/param_types.go 34.0% 31.6% -2.4
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 90.0% 87.1% -2.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go 95.2% 90.9% -4.3
pkg/apis/pipeline/v1beta1/param_types.go 34.0% 31.6% -2.4
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 90.0% 87.1% -2.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go 95.2% 90.9% -4.3
pkg/apis/pipeline/v1beta1/param_types.go 34.0% 31.6% -2.4
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 90.0% 87.1% -2.9

@vdemeester vdemeester force-pushed the v1beta1-e2e-test branch 2 times, most recently from c0d05a5 to ee58ab4 Compare March 23, 2020 11:13
@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go 95.2% 90.9% -4.3
pkg/apis/pipeline/v1beta1/param_types.go 34.0% 31.6% -2.4
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 90.0% 87.1% -2.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go 95.2% 90.9% -4.3
pkg/apis/pipeline/v1beta1/param_types.go 34.0% 31.6% -2.4
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 90.0% 87.1% -2.9

@vdemeester
Copy link
Member Author

/test pull-tekton-pipeline-integration-tests

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go 95.2% 90.9% -4.3
pkg/apis/pipeline/v1beta1/param_types.go 34.0% 31.6% -2.4
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 90.0% 87.1% -2.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go 95.2% 90.9% -4.3
pkg/apis/pipeline/v1beta1/param_types.go 34.0% 31.6% -2.4
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 90.0% 87.1% -2.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go 95.2% 90.9% -4.3
pkg/apis/pipeline/v1beta1/param_types.go 34.0% 31.6% -2.4
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 90.0% 87.1% -2.9

@vdemeester vdemeester added area/testing Issues or PRs related to testing needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch labels Mar 24, 2020
@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go 95.2% 90.9% -4.3
pkg/apis/pipeline/v1beta1/param_types.go 34.0% 31.6% -2.4
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 90.0% 87.1% -2.9

@vdemeester
Introduce v1beta1 e2e go tests 📥
cd0aa28 
… and move v1alpha1 e2e go tests in their own package.

Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go 95.2% 90.9% -4.3
pkg/apis/pipeline/v1beta1/param_types.go 34.0% 31.6% -2.4
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 90.0% 87.1% -2.9

@vdemeester
Copy link
Member Author

It is green 🎉

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020
@ghost
Copy link

ghost commented Mar 24, 2020

I'm going to lgtm as well as approve this one despite its size. I've read through and feel pretty confident that this can go in, especially given that the blast radius is 99% testing and tests are passing. I'm also very eager to get the 0.11-rc3 release train moving.

/lgtm

@tekton-robot tekton-robot assigned ghost Mar 24, 2020
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020
@tekton-robot tekton-robot merged commit d6e21bc into tektoncd:master Mar 24, 2020
@vdemeester vdemeester deleted the v1beta1-e2e-test branch March 24, 2020 15:19
@ghost ghost removed the needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch label Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues or PRs related to testing cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vdemeester @tekton-robot @googlebot