Use `ko://` in e2e tests to exercices current code 🙃 #2902

vdemeester · 2020-07-06T12:37:58Z

Changes

Right now, some examples are exercicing old version of the code, and
definitely never the changes that would be on the images in a PR.
Using ko:// instead helps with that (e2e tests are using ko to
apply the samples).

Fixes #2883

/hold
Note: this means one cannot do a kubectl apply -f … on those files, which may be a problem ? 🤔
Most likely need #2675 to be in too 👼

Signed-off-by: Vincent Demeester [email protected]

/cc @bobcatfish @pritidesai @afrittoli @sbwsg

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices
Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

vdemeester · 2020-07-06T12:38:13Z

/cc @praveen4g0

tekton-robot · 2020-07-06T12:38:18Z

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/question: Issues or PRs that are questions around the project or a particular feature
kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

tekton-robot · 2020-07-06T12:38:19Z

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/question: Issues or PRs that are questions around the project or a particular feature
kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

vdemeester · 2020-07-06T12:38:20Z

/area testing
/kind misc

tekton-robot · 2020-07-06T12:38:23Z

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/question: Issues or PRs that are questions around the project or a particular feature
kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

tekton-robot · 2020-07-06T12:38:30Z

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/question: Issues or PRs that are questions around the project or a particular feature
kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

tekton-robot · 2020-07-06T12:38:42Z

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/question: Issues or PRs that are questions around the project or a particular feature
kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

tekton-robot · 2020-07-06T13:31:13Z

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/question: Issues or PRs that are questions around the project or a particular feature
kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

bobcatfish · 2020-07-06T13:32:09Z

Ah, finally a reason to be using ko instead of kubectl in the example tests XD

Note: this means one cannot do a kubectl apply -f … on those files, which may be a problem ? 🤔

I don't think so, at least the current test logic uses ko so that seems okay - i guess if you were casually applying an example you'd have trouble.

Maybe we could at least update the docs? https://github.com/tektoncd/pipeline/tree/master/examples#examples

vdemeester · 2020-07-06T14:31:49Z

Maybe we could at least update the docs? https://github.com/tektoncd/pipeline/tree/master/examples#examples

Indeed 😊

vdemeester · 2020-07-06T15:06:36Z

Legit failure 🤔

        >>> Container step-clone:
        2020/07/06 13:33:16 Error executing command: fork/exec /tekton/scripts/script-0-w4qr9: no such file or directory

pritidesai · 2020-07-06T23:12:41Z

/test pull-tekton-pipeline-integration-tests

tekton-robot · 2020-07-07T08:25:52Z

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/question: Issues or PRs that are questions around the project or a particular feature
kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

tekton-robot · 2020-07-07T09:27:09Z

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/question: Issues or PRs that are questions around the project or a particular feature
kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

tekton-robot · 2020-08-15T06:49:18Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

tekton-robot · 2020-08-15T06:49:18Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot · 2020-08-15T06:49:20Z

@tekton-robot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vdemeester · 2020-08-17T09:04:42Z

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

tekton-robot · 2020-08-17T09:04:44Z

@vdemeester: Reopened this PR.

In response to this:

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Right now, some examples are exercicing old version of the code, and definitely never the changes that would be on the images in a PR. Using `ko://` instead helps with that (e2e tests are using `ko` to apply the samples). This link `.ko.yaml` in test folder to use the proper base image (as `ko create …` seems to be running from the `test` folder). Signed-off-by: Vincent Demeester <[email protected]>

vdemeester · 2020-08-18T11:47:08Z

examples/v1beta1/pipelineruns/pipelinerun.yaml

+    securityContext:
+      runAsUser: 0


Because kaniko run as root, this has to run as root too, otherwise permission denied 😓

vdemeester · 2020-08-18T12:01:41Z

test/.ko.yaml

@@ -0,0 +1 @@
+../.ko.yaml


This is a symbolic link to .ko.yaml so that it uses the overrides from there instead of nothing.

vdemeester · 2020-08-18T12:01:50Z

/hold cancel

vdemeester · 2020-08-19T08:44:40Z

/cc @afrittoli @bobcatfish @sbwsg @imjasonh @dibyom

imjasonh · 2020-08-19T10:49:58Z

/lgtm

ghost · 2020-08-19T14:59:19Z

/approve

tekton-robot · 2020-08-19T17:27:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai, sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [pritidesai,sbwsg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot requested review from afrittoli, bobcatfish, pritidesai and a user July 6, 2020 12:37

tekton-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 6, 2020

tekton-robot requested a review from praveen4g0 July 6, 2020 12:38

tekton-robot added area/testing Issues or PRs related to testing kind/misc Categorizes issue or PR as a miscellaneuous one. labels Jul 6, 2020

bobcatfish added the kind/bug Categorizes issue or PR as related to a bug. label Jul 6, 2020

vdemeester force-pushed the 2883-examples-using-ko branch from 1bad4b1 to c62e278 Compare July 7, 2020 08:25

vdemeester force-pushed the 2883-examples-using-ko branch from c62e278 to c79d293 Compare July 7, 2020 09:26

vdemeester removed the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jul 7, 2020

vdemeester force-pushed the 2883-examples-using-ko branch from c79d293 to 7b27f96 Compare July 9, 2020 08:08

tekton-robot closed this Aug 15, 2020

tekton-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 15, 2020

tekton-robot reopened this Aug 17, 2020

tekton-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 17, 2020

vdemeester force-pushed the 2883-examples-using-ko branch from 7b27f96 to c728c08 Compare August 17, 2020 13:33

vdemeester force-pushed the 2883-examples-using-ko branch from 3b76484 to 0e1ea9b Compare August 18, 2020 11:46

tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2020

vdemeester commented Aug 18, 2020

View reviewed changes

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2020

tekton-robot requested review from dibyom and imjasonh August 19, 2020 08:44

tekton-robot assigned imjasonh Aug 19, 2020

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2020

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2020

pritidesai approved these changes Aug 19, 2020

View reviewed changes

tekton-robot merged commit 140a3be into tektoncd:master Aug 19, 2020

vdemeester deleted the 2883-examples-using-ko branch August 20, 2020 08:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use `ko://` in e2e tests to exercices current code 🙃 #2902

Use `ko://` in e2e tests to exercices current code 🙃 #2902

vdemeester commented Jul 6, 2020

vdemeester commented Jul 6, 2020

tekton-robot commented Jul 6, 2020

tekton-robot commented Jul 6, 2020

vdemeester commented Jul 6, 2020

tekton-robot commented Jul 6, 2020

tekton-robot commented Jul 6, 2020

tekton-robot commented Jul 6, 2020

tekton-robot commented Jul 6, 2020

bobcatfish commented Jul 6, 2020

vdemeester commented Jul 6, 2020

vdemeester commented Jul 6, 2020

pritidesai commented Jul 6, 2020

tekton-robot commented Jul 7, 2020

tekton-robot commented Jul 7, 2020

tekton-robot commented Aug 15, 2020

tekton-robot commented Aug 15, 2020

tekton-robot commented Aug 15, 2020

vdemeester commented Aug 17, 2020

tekton-robot commented Aug 17, 2020

vdemeester Aug 18, 2020

vdemeester Aug 18, 2020

vdemeester commented Aug 18, 2020

vdemeester commented Aug 19, 2020

imjasonh commented Aug 19, 2020

ghost commented Aug 19, 2020

tekton-robot commented Aug 19, 2020

		@@ -0,0 +1 @@
		../.ko.yaml

Use ko:// in e2e tests to exercices current code 🙃 #2902

Use ko:// in e2e tests to exercices current code 🙃 #2902

Conversation

vdemeester commented Jul 6, 2020

Changes

Submitter Checklist

Reviewer Notes

Release Notes

vdemeester commented Jul 6, 2020

tekton-robot commented Jul 6, 2020

tekton-robot commented Jul 6, 2020

vdemeester commented Jul 6, 2020

tekton-robot commented Jul 6, 2020

tekton-robot commented Jul 6, 2020

tekton-robot commented Jul 6, 2020

tekton-robot commented Jul 6, 2020

bobcatfish commented Jul 6, 2020

vdemeester commented Jul 6, 2020

vdemeester commented Jul 6, 2020

pritidesai commented Jul 6, 2020

tekton-robot commented Jul 7, 2020

tekton-robot commented Jul 7, 2020

tekton-robot commented Aug 15, 2020

tekton-robot commented Aug 15, 2020

tekton-robot commented Aug 15, 2020

vdemeester commented Aug 17, 2020

tekton-robot commented Aug 17, 2020

vdemeester Aug 18, 2020

Choose a reason for hiding this comment

vdemeester Aug 18, 2020

Choose a reason for hiding this comment

vdemeester commented Aug 18, 2020

vdemeester commented Aug 19, 2020

imjasonh commented Aug 19, 2020

ghost commented Aug 19, 2020

tekton-robot commented Aug 19, 2020

Use `ko://` in e2e tests to exercices current code 🙃 #2902

Use `ko://` in e2e tests to exercices current code 🙃 #2902