Add URL to the ResourcesResults returned by resources. #2975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/M
|
/kind feature |
tekton-robot
added
the
kind/feature
|
/test pull-tekton-pipeline-integration-tests |
Today, this contains commits and digests (for Git and Image Resources). These are great, but need the addition of a URL to really verify or fetch the content again. This could be fetched off the Resource itself, but that would require resolving the Resource (since it could be passed by reference and change after the fact). We decided not to dereference Resources into the Status because they are still alpha. This gives us the requried information, without coupling the beta API to an alpha field.
|
Just gave this one a rebase, it's ready for review. |
ghost
approved these changes
Aug 5, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
@dlorenc how do you feel about the equivalent Tasks in the catalog? (i guess there's just the git Task in this case, maybe the kaniko Task kinda counts) - feels like we should include this output for those as well? /lgtm |
dlorenc
pushed a commit
to dlorenc/catalog
that referenced
this pull request
Aug 25, 2020
This matches the behavior in PipelineResources after tektoncd/pipeline#2975
dlorenc
pushed a commit
to dlorenc/catalog
that referenced
this pull request
Aug 25, 2020
This matches the behavior in PipelineResources after tektoncd/pipeline#2975
8 tasks
dlorenc
pushed a commit
to dlorenc/catalog
that referenced
this pull request
Aug 25, 2020
This matches the behavior in PipelineResources after tektoncd/pipeline#2975
tekton-robot
pushed a commit
to tektoncd/catalog
that referenced
this pull request
Sep 3, 2020
This matches the behavior in PipelineResources after tektoncd/pipeline#2975
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Today, this contains commits and digests (for Git and Image Resources). These are great,
but need the addition of a URL to really verify or fetch the content again. This could be
fetched off the Resource itself, but that would require resolving the Resource (since it could
be passed by reference and change after the fact).
We decided not to dereference Resources into the Status because they are still alpha. This
gives us the requried information, without coupling the beta API to an alpha field.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes