Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an error formatting in taskrun reconciler #3073

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Fix an error formatting in taskrun reconciler #3073

merged 1 commit into from
Aug 20, 2020

Conversation

NavidZ
Copy link
Member

@NavidZ NavidZ commented Aug 7, 2020 •
edited
Loading

Changes

Fix an error formatting in taskrun reconciler

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Aug 7, 2020
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 7, 2020
@tekton-robot
Copy link
Collaborator

Hi @NavidZ. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 7, 2020
danielhelfand
danielhelfand reviewed Aug 7, 2020
View reviewed changes
pkg/reconciler/taskrun/taskrun.go Outdated
@@ -376,7 +376,7 @@ func (c *Reconciler) reconcile(ctx context.Context, tr *v1beta1.TaskRun,
pod, err = c.createPod(ctx, tr, rtr)
if err != nil {
newErr := c.handlePodCreationError(ctx, tr, err)
logger.Error("Failed to create task run pod for task %q: %v", tr.Name, newErr)
logger.Errorf("Failed to create task run pod for task %q: %v", tr.Name, newErr)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another issue with this appears to be that the error is stating that the added name is for the task, but the actual value is tr.Name. Should it not be the following:

Suggested change
logger.Errorf("Failed to create task run pod for task %q: %v", tr.Name, newErr)
logger.Errorf("Failed to create task run pod for taskrun %q: %v", tr.Name, newErr)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Fixed!

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2020
@NavidZ NavidZ force-pushed the error-formatting branch from 25781df to 0165d07 Compare August 7, 2020 15:47
@danielhelfand
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 7, 2020
@danielhelfand
Copy link
Member

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 7, 2020
@pritidesai
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2020
@pritidesai
Copy link
Member

/test check-pr-has-kind-label

@vdemeester vdemeester added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 10, 2020
@vdemeester
Copy link
Member

/test pull-tekton-pipeline-integration-tests

@vdemeester vdemeester added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 20, 2020
@tekton-robot tekton-robot merged commit 9f1f85b into tektoncd:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhelfand danielhelfand danielhelfand left review comments

@dibyom dibyom Awaiting requested review from dibyom

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@pritidesai pritidesai

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NavidZ @tekton-robot @danielhelfand @pritidesai @vdemeester