Add Conditions CRD to deprecated features list #3150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
do-not-merge/work-in-progress
tekton-robot
added
the
size/XS
jerop
changed the title
|
/kind documentation |
tekton-robot
added
the
kind/documentation
|
@bobcatfish opened it separately because at the time #3135 would be merged, I wouldn't have the release announcement to reference on the deprecation table, so i'd still have to edit this table after #3135 is merged -- opened this as a draft now so that i don't forget to do it later |
|
ah kk, thanks for explaining @jerop ! |
vdemeester
approved these changes
Sep 8, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
jerop
force-pushed
the
conditions-deprecated
branch
4 times, most recently
from
6709c5c to
dceeaea
Compare
tekton-robot
removed
the
do-not-merge/work-in-progress
Use `WhenExpressions` instead The [API compatibility policy](https://github.com/tektoncd/pipeline/blob/master/api_compatibility_policy.md#alpha-beta-and-ga) states that Alpha features may be dropped at any time, though users will be given at least one release worth of warning.So we're giving two releases warning on deprecation. PR: tektoncd#3135 TEP: https://github.com/tektoncd/community/blob/master/teps/0007-conditions-beta.md
jerop
force-pushed
the
conditions-deprecated
branch
from
dceeaea to
5e9320e
Compare
jerop
commented
Sep 8, 2020
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update the deprecated features list to include
ConditionsCRD. Users should useWhenExpressionsinstead.PR: #3135
TEP: https://github.com/tektoncd/community/blob/master/teps/0007-conditions-beta.md
The API compatibility policy states that Alpha features may be dropped at any time, though users will be given at least one release worth of warning.
So we're giving two releases warning on deprecation.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes