Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pkg/system. #3177

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Remove pkg/system. #3177

merged 1 commit into from
Jan 13, 2021

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Sep 8, 2020 •
edited
Loading

Changes

This is almost identical to the code in knative/pkg/system which we already
import and use in a few cases.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

The controller now requires that the SYSTEM_NAMESPACE environment variable is set. This was set by default before, but is now required.

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Sep 8, 2020
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 8, 2020
@dlorenc
Copy link
Contributor Author

dlorenc commented Sep 8, 2020

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 8, 2020
@dlorenc
Copy link
Contributor Author

dlorenc commented Sep 8, 2020

/kind cleanup

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2020
@afrittoli afrittoli added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 8, 2020
vdemeester
vdemeester reviewed Sep 9, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment — it shouldn't affect user that much but… it might for some.
/cc @skaegi @chhsia0

pkg/system/names.go Show resolved Hide resolved
pkg/reconciler/taskrun/taskrun_test.go Outdated Show resolved Hide resolved
@tekton-robot tekton-robot requested a review from skaegi September 9, 2020 06:59
@tekton-robot
Copy link
Collaborator

@vdemeester: GitHub didn't allow me to request PR reviews from the following users: chhsia0.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

One comment — it shouldn't affect user that much but… it might for some.
/cc @skaegi @chhsia0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bobcatfish
bobcatfish reviewed Sep 9, 2020
View reviewed changes
Copy link
Collaborator

@bobcatfish bobcatfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

pkg/system/names.go Show resolved Hide resolved
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Sep 10, 2020
@imjasonh
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2020
@imjasonh
Copy link
Member

/retest

@vdemeester
Copy link
Member 

pkg/reconciler/pipelinerun/affinity_assistant_test.go:171:86: undefined: system.GetNamespace

@dlorenc I think there is some legit failure in there (due to a rebase).

/lgtm cancel

@tekton-robot tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels Oct 7, 2020
@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2021
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2021
@vdemeester
Copy link
Member

/remove-lifecycle stale

@tekton-robot tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 7, 2021
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2021
@dlorenc dlorenc force-pushed the system branch 2 times, most recently from 5208512 to eee14fe Compare January 13, 2021 13:35
Remove pkg/system.
a87b220 
This is almost identical to the code in knative/pkg/system which we already
import and use in a few cases.

Signed-off-by: Dan Lorenc <[email protected]>
@dlorenc
Copy link
Contributor Author

dlorenc commented Jan 13, 2021

/test tekton-pipeline-unit-tests

@vdemeester
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2021
@imjasonh
Copy link
Member

/lgtm

@tekton-robot tekton-robot merged commit 98efbf1 into tektoncd:master Jan 13, 2021
pritidesai added a commit to pritidesai/experimental that referenced this pull request Mar 12, 2021
@pritidesai
update pipelines version
ca68ffb 
Use the latest pipelines version 0.22.0, moving away from v0.20.0.

Up until v0.20.0, pipelines had pkg/system to retrieve the namespace which
was dropped in favor of knative.dev/pkg/system, see PR
tektoncd/pipeline#3177

Applying changes to use knative.dev/pkg/system.
@pritidesai pritidesai mentioned this pull request Mar 12, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobcatfish bobcatfish bobcatfish left review comments

@vdemeester vdemeester vdemeester left review comments

@skaegi skaegi Awaiting requested review from skaegi

Assignees

@vdemeester vdemeester

@imjasonh imjasonh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dlorenc @tekton-robot @imjasonh @vdemeester @bobcatfish @afrittoli