Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some tests for pkg/git/git.go #3523

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Add some tests for pkg/git/git.go #3523

merged 1 commit into from
Nov 30, 2020

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Nov 14, 2020

Changes

Add some more tests for pkg/git/git.go

We are creating a fake local git repo where to clone from to avoid
network flakiness.

/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • [NA] Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • [NA] Release notes block has been filled in or deleted (only if no user facing changes)
NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 14, 2020
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/git/git.go 2.4% 15.9% 13.5

@chmouel chmouel changed the title Add some tests for pkg/git/git.com Add some tests for pkg/git/git.go Nov 14, 2020
@chmouel
Copy link
Member Author

chmouel commented Nov 14, 2020

Weird unit-tests definitively pass under my VM, let's see why it's failing on CI,

@chmouel
Copy link
Member Author

chmouel commented Nov 16, 2020

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2020
@chmouel
Add some tests for pkg/git/git.com
bc1a277 
Add some more tests for pkg/git/git.go

We are creating a fake local git repo where to clone from to avoid
network flakiness.

Signed-off-by: Chmouel Boudjnah <[email protected]>
@chmouel chmouel force-pushed the add-test-for-git-clone branch from cd7584b to bc1a277 Compare November 30, 2020 10:39
@chmouel
Copy link
Member Author

chmouel commented Nov 30, 2020

/hold cancel

Tested (and fixed it) locally with gcr.io/tekton-releases/dogfooding/test-runner let's see if it works now

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2020
@chmouel
Copy link
Member Author

chmouel commented Nov 30, 2020

/retest

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/git/git.go 2.4% 55.6% 53.2

@chmouel
Copy link
Member Author

chmouel commented Nov 30, 2020

/retest

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2020
@ghost
Copy link

ghost commented Nov 30, 2020

/lgtm

@tekton-robot tekton-robot assigned ghost Nov 30, 2020
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2020
@tekton-robot tekton-robot merged commit d15def7 into tektoncd:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chmouel @tekton-robot @vdemeester