Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump deps - k8s to 1.19.7 #3724

Merged
merged 3 commits into from
Jan 28, 2021
Merged

bump deps - k8s to 1.19.7 #3724

merged 3 commits into from
Jan 28, 2021

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Jan 27, 2021 •
edited
Loading

Bumped K8s, Knative, GGCR deps

replace block was removed since we don't need it anymore

/kind cleanup

NONE

@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jan 27, 2021
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 27, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2021
@tekton-robot
Copy link
Collaborator

Hi @dprotaso. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 27, 2021
imjasonh
imjasonh reviewed Jan 27, 2021
View reviewed changes
Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2021
@dprotaso
Copy link
Contributor Author

dprotaso commented Jan 27, 2021 •
edited
Loading

blah folder case changed in some upstream k8s dep - one sec

@dprotaso
Copy link
Contributor Author

codegen

@dprotaso
Copy link
Contributor Author

so weird - I run it locally with no diff

@dprotaso
Copy link
Contributor Author

dprotaso commented Jan 27, 2021 •
edited
Loading

lol it's path dependent

- Ref: ref("github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1.Step"),
+ Ref: ref("knative.dev/build-pipeline/pkg/apis/pipeline/v1beta1.Step"),

@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 27, 2021
@imjasonh
Copy link
Member

/test check-pr-has-kind-label

@dprotaso
Copy link
Contributor Author

rebased

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2021
@vdemeester
Copy link
Member

@dprotaso one very naive question : why is it needed now (as compared to when knative 0.21 is released 😝) ?
Otherwise, looks good 😉

@dprotaso
Copy link
Contributor Author

I was doing this to drop the replace blocks in in https://github.com/mattmoor/mink which pulls in tekton

If you prefer to be more conservative with your knative/pkg adoption I can close the PR and re-open it when 0.21 ships

@vdemeester
Copy link
Member

I was doing this to drop the replace blocks in in https://github.com/mattmoor/mink which pulls in tekton

If you prefer to be more conservative with your knative/pkg adoption I can close the PR and re-open it when 0.21 ships

Honestly that's ok, from time to time we do bump non tagged version of knative/pkg. As long as we have a issue in the our 0.21 to make sure we bump knative to the released version, I am fine merging this.

/lgtm
/hold

/cc @jerop @sbwsg to make sure the release captain agree with this as this make us have to wait for knative/* to be release as 0.21. Please remove the hold if you are ok with it 😉

@tekton-robot tekton-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jan 28, 2021
@dprotaso dprotaso mentioned this pull request Jan 28, 2021
Merged
jerop
jerop reviewed Jan 28, 2021
View reviewed changes
Copy link
Member

@jerop jerop left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @jerop @sbwsg to make sure the release captain agree with this as this make us have to wait for knative/* to be release as 0.21. Please remove the hold if you are ok with it 😉

we agreed in the owners meeting on monday to wait for knative 0.21 (~ 15th Feb) then do our release a few days later

#3324 is in our next release milestone (comment)

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2021
@tekton-robot tekton-robot merged commit 1eca890 into tektoncd:master Jan 28, 2021
@vdemeester
Copy link
Member

thx @jerop 🤗

@dprotaso
Copy link
Contributor Author

Fixes #3324

@dprotaso dprotaso mentioned this pull request Jan 28, 2021
Merged
@afrittoli afrittoli mentioned this pull request Feb 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop left review comments

@imjasonh imjasonh imjasonh approved these changes

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dprotaso @tekton-robot @imjasonh @vdemeester @jerop