Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump ggcr & k8schain module versions #3736

Merged
merged 2 commits into from
Feb 3, 2021
Merged

bump ggcr & k8schain module versions #3736

merged 2 commits into from
Feb 3, 2021

Conversation

dprotaso
Copy link
Contributor

I manually bumped the version of github.com/google/go-containerregistry & it's k8schain module.

k8schain was bumped to use the latest version (v1.19.7) of github.com/vdemeester/k8s-pkg-credentialprovider.

This should drop any transient k8s.io v1.18 deps - see tektoncd/triggers#934 (comment)

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jan 30, 2021
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 30, 2021
@tekton-robot
Copy link
Collaborator

Hi @dprotaso. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 30, 2021
@dprotaso dprotaso changed the title bump ggcr & k8schain bump ggcr & k8schain module versions Jan 30, 2021
@vdemeester
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 1, 2021
vdemeester
vdemeester reviewed Feb 1, 2021
View reviewed changes
go.mod
Comment on lines +7 to +16
github.com/Azure/azure-sdk-for-go v50.2.0+incompatible // indirect
github.com/Azure/go-autorest/autorest v0.11.17 // indirect
github.com/Azure/go-autorest/autorest/adal v0.9.10 // indirect
github.com/Azure/go-autorest/autorest/to v0.4.0 // indirect
github.com/Azure/go-autorest/autorest/validation v0.3.1 // indirect
github.com/GoogleCloudPlatform/cloud-builders/gcs-fetcher v0.0.0-20191203181535-308b93ad1f39
github.com/aws/aws-sdk-go v1.37.1 // indirect
github.com/cloudevents/sdk-go/v2 v2.1.0
github.com/docker/cli v20.10.2+incompatible // indirect
github.com/docker/docker v20.10.2+incompatible // indirect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of new deps 😅

Copy link
Contributor Author

@dprotaso dprotaso Feb 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the deps have been there before - unclear when the go toolchain adds it to the go.mod file with //indirect now

@dprotaso
Copy link
Contributor Author

dprotaso commented Feb 1, 2021

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 1, 2021
@vdemeester
Copy link
Member

/approve
/cc @tektoncd/core-maintainers

@tekton-robot tekton-robot requested a review from a team February 2, 2021 17:30
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2021
@ghost
Copy link

ghost commented Feb 2, 2021

/lgtm

@tekton-robot tekton-robot assigned ghost Feb 2, 2021
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2021
@pritidesai pritidesai mentioned this pull request Feb 3, 2021
Merged
4 tasks
@vdemeester
Copy link
Member

/retest

1 similar comment
@vdemeester
Copy link
Member

/retest

@tekton-robot tekton-robot merged commit 1b7a37f into tektoncd:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester left review comments

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dprotaso @tekton-robot @vdemeester