Pull request template spring cleaning 🌷 #3866
Conversation
I removed the blocks on reviewer notes and on updating the release pipeline for new images because I don't get the impression these were serving any useful purponse; and I think having noise in the pull request template might distract people from the important bits, like the checklist which is still often ignored :( I also tried to update the checklist to refer our new(ish) guidelines since I don't think the existing links actually worked anymore 😬
tekton-robot
added
release-note-none
|
@tektoncd/core-maintainers |
tekton-robot
added
the
size/S
|
p.s. shout out to @shuheiktgw for fixing these links in triggers!! (tektoncd/triggers#844) thank you! 🙏 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test check-pr-has-kind-label |
1 similar comment
|
/test check-pr-has-kind-label |
|
Uhm... the webhook is returning 500, not sure why... investigating |
|
/test check-pr-has-kind-label |
1 similar comment
|
/test check-pr-has-kind-label |
Changes
I removed the blocks on reviewer notes and on updating the release
pipeline for new images because I don't get the impression these were
serving any useful purponse; and I think having noise in the pull
request template might distract people from the important bits, like the
checklist which is still often ignored :(
I also tried to update the checklist to refer our new(ish) guidelines
since I don't think the existing links actually worked anymore 😬
/kind cleanup
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes