Build entrypoint image for Windows #4260
Conversation
tekton-robot
added
do-not-merge/work-in-progress
tekton-robot
added
the
size/S
|
@DrWadsy requested that we add this to the next milestone (cc @tektoncd/core-maintainers) |
|
Is this PR still WIP or ready for review now @imjasonh ? |
|
Still need this to be able to build for Windows, but it's still not ready. I'll try to find time to make progress, if someone else wants to pick it up I won't argue. |
|
This is now blocked on picking up tektoncd/plumbing#901, it should be good to test after that PR is merged and this PR picks it up. |
This uses the cmd/combine tool in the plumbing repo to build a combined base image from distroless and Windows, which cmd/entrypoint will build on.
imjasonh
changed the title
tekton-robot
removed
the
do-not-merge/work-in-progress
|
Test failures appear to be unrelated flakes /test pull-tekton-pipeline-integration-tests |
/test pull-tekton-pipeline-alpha-integration-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
| # Combine Distroless with a Windows base image, used for the entrypoint image. | ||
| COMBINED_BASE_IMAGE=$(go run ./vendor/github.com/tektoncd/plumbing/cmd/combine/main.go \ | ||
| gcr.io/distroless/base:debug-nonroot \ | ||
| mcr.microsoft.com/windows/nanoserver:1809 \ |
There was a problem hiding this comment.
Perhaps a comment on the 1809 tag?
|
/lgtm |
Previously, create-ko-yaml didn't need to be run in ${PROJECT_ROOT}, but
after tektoncd#4260 it tries to `go run` something assuming it's in
${PROJECT_ROOT}, which fails unless we `cd` into that directory.
Previously, create-ko-yaml didn't need to be run in ${PROJECT_ROOT}, but
after #4260 it tries to `go run` something assuming it's in
${PROJECT_ROOT}, which fails unless we `cd` into that directory.
Previously, create-ko-yaml didn't need to be run in ${PROJECT_ROOT}, but
after tektoncd#4260 it tries to `go run` something assuming it's in
${PROJECT_ROOT}, which fails unless we `cd` into that directory.
#1826
/kind feature
Changes
Uses plumbing's
cmd/combineto build a combined distroless-and-Windows multi-arch base image, then uses that image as the base image for the entrypoint image so that it can be built for Windows.Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes