Generate reconcilers for [Cluster]Tasks and Pipelines.
#4293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/XS
mattmoor
commented
Oct 9, 2021
| @@ -42,8 +42,9 @@ const ( | |||
| ) | |||
|
|
|||
| // +genclient | |||
| // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object | |||
There was a problem hiding this comment.
I rearranged this for consistency, but I'd be happy to change it back if folks care.
|
/kind misc |
|
Woof, go 1.17 is making codegen upset :-/ |
We want to write a reconciler (downstream) that acts on these abstract task definitions, but we don't currently generate reconcilers for these types. This adds the codegen comments needed to produce the reconcilers and runs `./hack/update-codegen.sh`.
mattmoor
force-pushed
the
genreconciler-tasks
branch
from
4435215 to
7a859d2
Compare
|
/retest |
mattmoor
added a commit
to mattmoor/pipeline
that referenced
this pull request
Oct 9, 2021
This is somewhat related to tektoncd#4293, in that a common thing to do one reconciling a certain primary resource is to hang child resources off of it. A simple example of this might be if you wanted to create Knative `Image` resources for the images in a `TaskRun` to direct a caching system to warm those images on builder nodes.
mattmoor
added a commit
to mattmoor/pipeline
that referenced
this pull request
Oct 9, 2021
This is somewhat related to tektoncd#4293, in that a common thing to do one reconciling a certain primary resource is to hang child resources off of it. A simple example of this might be if you wanted to create Knative `Image` resources for the images in a `TaskRun` to direct a caching system to warm those images on builder nodes.
4 tasks
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlorenc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
tekton-robot
pushed a commit
that referenced
this pull request
Oct 11, 2021
This is somewhat related to #4293, in that a common thing to do one reconciling a certain primary resource is to hang child resources off of it. A simple example of this might be if you wanted to create Knative `Image` resources for the images in a `TaskRun` to direct a caching system to warm those images on builder nodes.
|
Alpha test flake /retest |
chenbh
pushed a commit
to chenbh/pipeline
that referenced
this pull request
Oct 27, 2021
This is somewhat related to tektoncd#4293, in that a common thing to do one reconciling a certain primary resource is to hang child resources off of it. A simple example of this might be if you wanted to create Knative `Image` resources for the images in a `TaskRun` to direct a caching system to warm those images on builder nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to write a reconciler (downstream) that acts on these abstract
task definitions, but we don't currently generate reconcilers for these
types. This adds the codegen comments needed to produce the reconcilers
and runs
./hack/update-codegen.sh./kind enhancement
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes