Fix unreachable code in TestReconcileCancelledFailsTaskRunCancellation
#4312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Code in
TestReconcileCancelledFailsTaskRunCancellation
was never going to be reached - it was getting a value from a map and fataling if the key wasn't present, and then the actual test logic for that value was in the same block as thet.Fatalf
. I rearranged that, and also made the test logic for the value be valid - it was expectingtest-pipelines
as the value, but the value was actually alwaystest-pipeline
(singular!)./kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes