Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Windows builds of cmd/nop in release process #4474

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

imjasonh
Copy link
Member

Fixes #4471

Changes

This uses the same multi-platform-and-multi-OS base image used for the entrypoint image to ensure that the nop image used for Affinity Assistant, etc., is also built for Windows.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

Include Windows support for the nop image, to enable Affinity Assistant for Windows, and more.

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 12, 2022
@imjasonh
Copy link
Member Author

cc @lippertmarkus

@imjasonh
Copy link
Member Author

/test tekton-pipeline-unit-tests

@imjasonh
Copy link
Member Author

/test pull-tekton-pipeline-alpha-integration-tests

@ghost
Copy link

ghost commented Jan 13, 2022

/lgtm

@tekton-robot tekton-robot assigned ghost Jan 13, 2022
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2022
@tekton-robot tekton-robot merged commit 65477d5 into tektoncd:main Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows containers: Affinity assistant doesn't work as there's no Windows nop image
3 participants