Drop resource requests: from gohelloworld.
#4549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resource requests are used to decide whether a pod may be scheduled on a node. In some of our downstream testing we have been seeing a rash of flakes in `TestHelmDeployPipelineRun` which manifest as follows. The pipeline itself times out waiting for the test to complete: ``` 2022-02-05T03:06:49.873527563Z stderr F wait.go:244: [debug] Deployment is not ready: arendelle-7wpjd/gohelloworld-chart. 0 out of 1 expected pods are ready 2022-02-05T03:06:51.905640413Z stderr F wait.go:244: [debug] Deployment is not ready: arendelle-7wpjd/gohelloworld-chart. 0 out of 1 expected pods are ready 2022-02-05T03:06:54.013351746Z stderr F wait.go:244: [debug] Deployment is not ready: arendelle-7wpjd/gohelloworld-chart. 0 out of 1 expected pods are ready 2022-02-05T03:06:55.814048343Z stderr F wait.go:244: [debug] Deployment is not ready: arendelle-7wpjd/gohelloworld-chart. 0 out of 1 expected pods are ready 2022-02-05T03:06:55.822633914Z stderr F wait.go:244: [debug] Deployment is not ready: arendelle-7wpjd/gohelloworld-chart. 0 out of 1 expected pods are ready 2022-02-05T03:06:56.162347025Z stderr F Error: timed out waiting for the condition 2022-02-05T03:06:56.165538751Z stderr F helm.go:81: [debug] timed out waiting for the condition ``` However, a brief while later: ``` 2022-02-05T03:08:36.385531093Z stderr F 2022/02/05 03:08:36 Hello world sample started. 2022-02-05T03:08:37.246650188Z stderr F 2022/02/05 03:08:37 Hello world received a request. 2022-02-05T03:08:45.852975472Z stderr F 2022/02/05 03:08:45 Hello world received a request. 2022-02-05T03:08:45.856908405Z stderr F 2022/02/05 03:08:45 Hello world received a request. 2022-02-05T03:08:55.851238051Z stderr F 2022/02/05 03:08:55 Hello world received a request. 2022-02-05T03:08:55.855837089Z stderr F 2022/02/05 03:08:55 Hello world received a request. ``` I believe that the core issue here is that it times out because the pod cannot be scheduled, likely because the KinD cluster we're on is very busy. An alternative here might be to (dramatically) lower the resource requests, but I'm not sure they are providing any real value today. Related: tektoncd#4455
tekton-robot
added
the
release-note
tekton-robot
added
the
size/XS
imjasonh
approved these changes
Feb 7, 2022
tekton-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: imjasonh, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource requests are used to decide whether a pod may be scheduled on a node. In some of our downstream testing we have been seeing a rash of flakes in
TestHelmDeployPipelineRunwhich manifest as follows.The pipeline itself times out waiting for the test to complete:
However, a brief while later:
I believe that the core issue here is that it times out because the pod cannot be scheduled, likely because the KinD cluster we're on is very busy.
An alternative here might be to (dramatically) lower the resource requests, but I'm not sure they are providing any real value today.
Related: #4455
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes