Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEP-0090: Matrix - Results #4707

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Conversation

jerop
Copy link
Member

@jerop jerop commented Mar 23, 2022

Changes

TEP-0090 proposed executing a PipelineTask in parallel TaskRuns and Runs with substitutions from combinations of Parameters in a Matrix.

In this change, we add validation that dynamic fan out of PipelineTasks through consuming Results in Matrix is not yet supported. We plan to support dynamic fan out after gathering feedback on static fan out only.

In this change, we also add validation that Results from fanned out PipelineTasks are not consumed. We plan to revisit this after array and object Results are supported.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

-  Consuming `Results` in `Matrix` is invalid - will be supported soon to allow dynamic fan out.
-  Consuming `Results` from fanned out `PipelineTasks` is invalid - will be revisited soon after array and object `Results` are supported. 

[TEP-0090][tep-0090] proposed executing a `PipelineTask` in parallel
`TaskRuns` and `Runs` with substitutions from combinations of
`Parameters` in a `Matrix`.

In this change, we add validation that dynamic fan out of `PipelineTasks`
through consuming `Results` in `Matrix` is not yet supported. We plan to
support dynamic fan out after gathering feedback on static fan out only.

In this change, we also add validation that `Results` from fanned out
`PipelineTasks` are not consumed. We plan to revisit this after array
and object `Results` are supported.

[tep-0090]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Mar 23, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 23, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/param_types.go 98.1% 98.1% 0.1
pkg/apis/pipeline/v1beta1/pipeline_types.go 96.3% 96.4% 0.1

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2022
@ghost
Copy link

ghost commented Mar 24, 2022

/lgtm

@tekton-robot tekton-robot assigned ghost Mar 24, 2022
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2022
@tekton-robot tekton-robot merged commit 20ba061 into tektoncd:main Mar 24, 2022
@jerop jerop deleted the tep-0090-results branch June 11, 2022 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants