Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract parameter name without any pattern. #4857

Conversation

chitrangpatel
Copy link
Contributor

@chitrangpatel chitrangpatel commented May 11, 2022

Extract parameter name without any pattern.

We want to extract everything that NAME contains in ($param.<NAME> | $param.<NAME>[*])
or (param["<NAME>"] | $param["<NAME>"][*]) or (param['NAME'][*] | $param['<NAME>'][*]).
We dont want to enforce the pattern that it should follow. That part should be done by
Step 1 in #4799 (comment)

Changes

The regex pattern substitution .*?(\[\*\])? matches and extracts everything that is contained in <NAME> or <NAME>[*].

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

Extract parameter name without any pattern.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 11, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 11, 2022
@chitrangpatel chitrangpatel changed the title Extract parameter name without any firm pattern. Extract parameter name without any pattern. May 11, 2022
@chitrangpatel chitrangpatel force-pushed the Extract-parameter-name-without-format branch from cb7e7d2 to 89598db Compare May 11, 2022 18:32
@chuangw6
Copy link
Member

/test tekton-pipeline-unit-tests

@chuangw6 chuangw6 mentioned this pull request May 11, 2022
5 tasks
@chitrangpatel
Copy link
Contributor Author

/assign @pritidesai

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 18, 2022
We want to extract everything that `NAME` contains in (`$param.<NAME> | $param.<NAME>[*]`)
or (`param["<NAME>"] | $param["<NAME>"][*]`) or (`param['NAME'][*] | $param['<NAME>'][*]`).
We dont want to enforce the pattern that it should follow. That part should be done by
`Step 1` in tektoncd#4799 (comment)

The regex pattern substitution `.*?(\[\*\])?` matches and extracts everything that is
contained in `<NAME>` or `<NAME>[*]`.
@chitrangpatel chitrangpatel force-pushed the Extract-parameter-name-without-format branch from 89598db to ae78819 Compare May 18, 2022 19:58
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 18, 2022
@chitrangpatel
Copy link
Contributor Author

/retest

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2022
@abayer
Copy link
Contributor

abayer commented Jun 30, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022
@vdemeester
Copy link
Member

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jul 4, 2022
@tekton-robot tekton-robot merged commit 5945829 into tektoncd:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants