-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract parameter name without any pattern. #4857
Extract parameter name without any pattern. #4857
Conversation
cb7e7d2
to
89598db
Compare
/test tekton-pipeline-unit-tests |
/assign @pritidesai |
We want to extract everything that `NAME` contains in (`$param.<NAME> | $param.<NAME>[*]`) or (`param["<NAME>"] | $param["<NAME>"][*]`) or (`param['NAME'][*] | $param['<NAME>'][*]`). We dont want to enforce the pattern that it should follow. That part should be done by `Step 1` in tektoncd#4799 (comment) The regex pattern substitution `.*?(\[\*\])?` matches and extracts everything that is contained in `<NAME>` or `<NAME>[*]`.
89598db
to
ae78819
Compare
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/kind misc |
Extract parameter name without any pattern.
We want to extract everything that
NAME
contains in ($param.<NAME> | $param.<NAME>[*]
)or (
param["<NAME>"] | $param["<NAME>"][*]
) or (param['NAME'][*] | $param['<NAME>'][*]
).We dont want to enforce the pattern that it should follow. That part should be done by
Step 1
in #4799 (comment)Changes
The regex pattern substitution
.*?(\[\*\])?
matches and extracts everything that is contained in<NAME>
or<NAME>[*]
.Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
(if there are no user facing changes, use release note "NONE")
Release Notes