remove spec.replicas from tekton-pipelines-webhook Deployment

[sellitforcache]

Changes

Simply removing the spec.replicas field from the tekton-pipelines-webhook Deployment since it has a HPA, and having this field would cause the webhook to scale to 1 replica upon re-application.

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Docs included if any changes are user facing
• Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Release notes block below has been filled in
  (if there are no user facing changes, use release note "NONE")

Release Notes

Unset replicas:1 in the webhook Deployment; HPA will autoscale the deployment (1-5 replicas by default).  First reapplication after this change will cause scaling down to 1 replica, but subsequent reapplications will not change the HPA-set replica number.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: sellitforcache / name: Ryan M. Bergmann (fe3cfab)

[tekton-robot]

Hi @sellitforcache. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[imjasonh]

Thank you for sending a PR! 🎉

I've got #4893 which unsets and adds a comment for future explorers. I don't feel strongly about one or the other though.

[sellitforcache]

Thank you for sending a PR! 🎉

I've got #4893 which unsets and adds a comment for future explorers. I don't feel strongly about one or the other though.

I'd love to be a contributor :). I'll add a release note...

[imjasonh]

I'd love to be a contributor :). I'll add a release note...

Great! You'll also need to sign the CLA.

[sellitforcache]

I'd love to be a contributor :). I'll add a release note...

Great! You'll also need to sign the CLA.

Done!

[imjasonh]

/ok-to-test

[imjasonh]

/test pull-tekton-pipeline-alpha-integration-tests

(flake)

[vdemeester]

/retest
/lgtm

[sellitforcache]

do I need to resign the CLA with the link in the checklist instead of the one you posted @imjasonh ?

[imjasonh]

Yeah maybe? We might also just need to poke clabot into checking again

[sellitforcache]

Ok I've signed again, just in case...

[imjasonh]

I think EasyCLA is having difficulty associating the commit author with the GitHub user you used to sign the CLA.

git config user.name "Your Name" # your name here
git config user.email "[email protected]" # the same email you used to sign the CLA
git commit --amend # to modify the commit to update the name & email
git push fork -f # to rewrite your fork to have the new commit

[vdemeester]

cc @tektoncd/operator-maintainers

[sellitforcache]

As far as I can tell, my git config matches my github account and the name/email I used to sign the CLA. I've pushed an amendment just in case, but it looks like EasyCLA is still having problems.

[vdemeester]

@sellitforcache I think Ryan Bergmann authored and [sellitforcache](https://github.com/sellitforcache/tektoncd-pipeline/commits?author=sellitforcache) committed 16 hours ago is still "messing" with EasyCLA. I tend to use --reset-author when ammending commit to make sure the author and commiter are the same, maybe you need to do the same.

git commit --reset-author --amend --no-edit

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lbernick]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sellitforcache]

@vdemeester thanks, done!

[vdemeester]

/lgtm

[vdemeester]

(damn.. wrong shortcut 😅 )

[vdemeester]

/lgtm

[sellitforcache]

/retest