TEP-0090: Matrix - Implement isRunning
#4981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
tekton-robot
added
the
size/L
|
cc @abayer @dibyom @lbernick @pritidesai please take a look |
|
The following is the coverage report on the affected files.
|
|
/lgtm |
|
/test pull-tekton-pipeline-alpha-integration-tests |
lbernick
reviewed
Jun 15, 2022
pkg/reconciler/pipelinerun/resources/pipelinerunresolution_test.go
Outdated
Show resolved
Hide resolved
[TEP-0090: Matrix][tep-0090] proposed executing a `PipelineTask` in parallel `TaskRuns` and `Runs` with substitutions from combinations of `Parameters` in a `Matrix`. In this change, we implement the `isRunning` member function of `ResolvedPipelineRunTask`. If the `ResolvedPipelineRunTask` is matrixed, it is running if any of its `TaskRuns` not completed. [tep-0090]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md
jerop
force-pushed
the
tep-0090-isrunning
branch
from
afa7ee4 to
9cff368
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
|
The following is the coverage report on the affected files.
|
jerop
added a commit
to jerop/pipeline
that referenced
this pull request
Jun 30, 2022
[TEP-0090: Matrix][tep-0090] proposed executing a `PipelineTask` in parallel `TaskRuns` and `Runs` with substitutions from combinations of `Parameters` in a `Matrix`. In this change, we implement the `isRunning` member function of `ResolvedPipelineTask` when the `PipelineTask` has a `Custom Task`. If the `ResolvedPipelineTask` is matrixed and is custom task, it is running if any of its `Runs` are not completed. Related PR: tektoncd#4981 [tep-0090]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md
4 tasks
tekton-robot
pushed a commit
that referenced
this pull request
Jul 1, 2022
[TEP-0090: Matrix][tep-0090] proposed executing a `PipelineTask` in parallel `TaskRuns` and `Runs` with substitutions from combinations of `Parameters` in a `Matrix`. In this change, we implement the `isRunning` member function of `ResolvedPipelineTask` when the `PipelineTask` has a `Custom Task`. If the `ResolvedPipelineTask` is matrixed and is custom task, it is running if any of its `Runs` are not completed. Related PR: #4981 [tep-0090]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
TEP-0090: Matrix proposed executing a
PipelineTaskinparallel
TaskRunsandRunswith substitutions from combinationsof
Parametersin aMatrix.In this change, we implement the
isRunningmember function ofResolvedPipelineRunTask. If theResolvedPipelineRunTaskismatrixed, it is running if any of its
TaskRunsnot completed./kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
Release Notes