-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup unused arguments - mostly removing unused ctx 🧹 #5028
Conversation
In this change, we cleanup unused arguments in functions, mostly removing unused "ctx".
/kind cleanup |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main reason it exists on SetDefaults
for example, is to make is Defaultable
. This is not necessary useful for non CRD types though, but I tend to like the consistency. But.. I also do not like when there is function param that are not used 😛
@vdemeester |
/lgtm |
Changes
In this change, we cleanup unused arguments in functions, mostly removing unused "ctx".
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes