Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0090: Matrix - Implement isSuccessful for Runs #5035

Merged
merged 1 commit into from
Jun 24, 2022
Merged

TEP-0090: Matrix - Implement isSuccessful for Runs #5035

merged 1 commit into from
Jun 24, 2022

Conversation

jerop
Copy link
Member

@jerop jerop commented Jun 24, 2022 •
edited
Loading

Changes

TEP-0090: Matrix proposed executing a PipelineTask in parallel TaskRuns and Runs with substitutions from combinations of Parameters in a Matrix.

In this change, we implement the isSuccessful member function of ResolvedPipelineRunTask for matrixed Runs.

If the ResolvedPipelineRunTask is matrixed, it is successful only if all of its Runs completed successfully.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in (if there are no user facing changes, use release note "NONE")

Release Notes

Matrixed `PipelineTasks` with `Custom Tasks` are successful when all `Runs` have completed successfully.

@jerop
TEP-0090: Matrix - Implement isSuccessful for Runs
b5a183d 
[TEP-0090: Matrix][tep-0090] proposed executing a `PipelineTask` in
parallel `TaskRuns` and `Runs` with substitutions from combinations
of `Parameters` in a `Matrix`.

In this change, we implement the `isSuccessful` member function
of `ResolvedPipelineRunTask` for matrixed `Runs`.

If the `ResolvedPipelineRunTask` is matrixed, it is successful only if
all of its `Runs` completed successfully.

[tep-0090]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 24, 2022
@jerop
Copy link
Member Author

jerop commented Jun 24, 2022

Related PR: #4980

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.1% 94.2% 0.1

@jerop
Copy link
Member Author

jerop commented Jun 24, 2022

@abayer @dibyom please take a look

@abayer
Copy link
Contributor

abayer commented Jun 24, 2022

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2022
@jerop
Copy link
Member Author

jerop commented Jun 24, 2022

/test pull-tekton-pipeline-integration-tests

@pritidesai
Copy link
Member

pritidesai commented Jun 24, 2022 •
edited
Loading

Tagging a PR as a feature without release notes is little misleading, please add a note if possible 🙏

thank you @jerop 👍

/lgtm

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Jun 24, 2022
@jerop
Copy link
Member Author

jerop commented Jun 24, 2022

@pritidesai had not included release notes because it's an implementation detail of a larger feature - added a note describing what this PR is doing though - or maybe what I should do is remove the "feature" label? 🤔

@pritidesai
Copy link
Member

@pritidesai had not included release notes because it's an implementation detail of a larger feature - added a note describing what this PR is doing though - or maybe what I should do is remove the "feature" label? 🤔

yeah that would be helpful. I generally like to collect notes for the feature PRs while creating a GitHub release page and making sure they are highlighted.

@tekton-robot tekton-robot merged commit 4c021dc into tektoncd:main Jun 24, 2022
@jerop jerop deleted the tep-0090-runs-issuccessful branch June 24, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pritidesai pritidesai Awaiting requested review from pritidesai

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@pritidesai pritidesai

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jerop @tekton-robot @abayer @pritidesai