Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0090: Get ChildReferences for Runs #5047

Merged
merged 1 commit into from
Jun 28, 2022
Merged

TEP-0090: Get ChildReferences for Runs #5047

merged 1 commit into from
Jun 28, 2022

Conversation

jerop
Copy link
Member

@jerop jerop commented Jun 27, 2022

Changes

TEP-0090: Matrix proposed executing a PipelineTask in parallel TaskRuns and Runs with substitutions from combinations of Parameters in a Matrix.

This change implements fetching of ChildReferences for Runs created from a matrixed PipelineTask.

/kind misc

Related PR: #5008

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Release notes block below has been filled in (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Jun 27, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 27, 2022
@jerop
Copy link
Member Author

jerop commented Jun 27, 2022

cc @abayer @dibyom @lbernick please take a look

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.3% 97.3% 0.0

@abayer
Copy link
Contributor

abayer commented Jun 27, 2022

Unit test failures seem legit?

@jerop
TEP-0090: Get ChildReferences for Runs
f3282a2 
[TEP-0090: Matrix][tep-0090] proposed executing a `PipelineTask` in
parallel `TaskRuns` and `Runs` with substitutions from combinations
of `Parameters` in a `Matrix`.

This change implements fetching of `ChildReferences` for `Runs`
created from a matrixed `PipelineTask`.

[tep-0090]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md
@jerop jerop force-pushed the tep-0090-getchildrefsforruns branch from 28ac12f to f3282a2 Compare June 27, 2022 22:20
@jerop
Copy link
Member Author

jerop commented Jun 27, 2022

@abayer was another last minute name change before pushing commit 🤦🏾‍♀️

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.3% 97.3% 0.0

@abayer
Copy link
Contributor

abayer commented Jun 27, 2022

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2022
@jerop
Copy link
Member Author

jerop commented Jun 27, 2022

level=error msg="Timeout exceeded: try increasing it by passing --timeout option"

/test pull-tekton-pipeline-build-tests
/test tekton-pipeline-unit-tests

dibyom
dibyom reviewed Jun 28, 2022
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2022
@tekton-robot tekton-robot merged commit 29f68de into tektoncd:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom left review comments

@abayer abayer Awaiting requested review from abayer

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jerop @tekton-robot @abayer @dibyom