Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0090: Resolve PipelineTask with Custom Task #5048

Merged
merged 1 commit into from
Jun 28, 2022
Merged

TEP-0090: Resolve PipelineTask with Custom Task #5048

merged 1 commit into from
Jun 28, 2022

Conversation

jerop
Copy link
Member

@jerop jerop commented Jun 27, 2022

Changes

TEP-0090: Matrix proposed executing a PipelineTask in parallel TaskRuns and Runs with substitutions from combinations of Parameters in a Matrix.

This change resolves a PipelineTask with a matrixed Custom Task.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Release notes block below has been filled in (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Jun 27, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 27, 2022
@jerop
Copy link
Member Author

jerop commented Jun 27, 2022

@abayer @dibyom @lbernick please take a look

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.2% 94.0% -0.2

@jerop jerop force-pushed the tep-0090-resolvepipelinetask-runs branch from d2b9e71 to 9a481a0 Compare June 27, 2022 20:41
@abayer
Copy link
Contributor

abayer commented Jun 27, 2022

Unit test failure seems legit.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.4% 94.0% -0.4

@jerop jerop force-pushed the tep-0090-resolvepipelinetask-runs branch 2 times, most recently from c855426 to 4a065bc Compare June 27, 2022 22:15
@jerop
TEP-0090: Resolve PipelineTask with Custom Task
a1f3046 
[TEP-0090: Matrix][tep-0090] proposed executing a `PipelineTask` in
parallel `TaskRuns` and `Runs` with substitutions from combinations
of `Parameters` in a `Matrix`.

This change resolves a `PipelineTask` with a matrixed `Custom Task`.

[tep-0090]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md
@jerop jerop force-pushed the tep-0090-resolvepipelinetask-runs branch from 4a065bc to a1f3046 Compare June 27, 2022 22:16
@jerop
Copy link
Member Author

jerop commented Jun 27, 2022

@abayer ah was a last minute change before pushing, fixed it 👍🏾

@abayer
Copy link
Contributor

abayer commented Jun 27, 2022

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.4% 94.2% -0.2

@jerop
Copy link
Member Author

jerop commented Jun 27, 2022

level=error msg="Timeout exceeded: try increasing it by passing --timeout option"

/test pull-tekton-pipeline-build-tests

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer, lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lbernick
Copy link
Member

/lgtm

since andrew already approved

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2022
@tekton-robot tekton-robot merged commit 8611c55 into tektoncd:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom left review comments

@lbernick lbernick lbernick approved these changes

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jerop @tekton-robot @abayer @lbernick @dibyom