Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0090: Fan Out Runs #5049

Merged
merged 1 commit into from
Jun 29, 2022
Merged

TEP-0090: Fan Out Runs #5049

merged 1 commit into from
Jun 29, 2022

Conversation

jerop
Copy link
Member

@jerop jerop commented Jun 28, 2022 •
edited
Loading

Changes

TEP-0090: Matrix proposed executing a PipelineTask in parallel TaskRuns and Runs with substitutions from combinations of Parameters in a Matrix.

This change implements the fan out of Runs from a PipelineTask with a Matrix. The fanned-out Runs are executed in parallel.

/kind feature

Related PR: #4990

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Release notes block below has been filled in (if there are no user facing changes, use release note "NONE")

Release Notes

A `PipelineTask` with a `Matrix` and `Custom Task` is fanned out into parallel `Runs` which are executed in parallel.

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 28, 2022
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 28, 2022
@jerop
Copy link
Member Author

jerop commented Jun 28, 2022

@abayer @lbernick @dibyom please take a look

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 86.3% 86.2% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.2% 94.2% 0.0
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.3% 97.4% 0.0

@jerop jerop force-pushed the tep-0090-fanout-runs branch 2 times, most recently from 95eaf95 to e76080f Compare June 28, 2022 21:14
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 86.3% 86.2% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.2% 94.2% 0.0
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.3% 97.4% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 86.3% 86.2% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.2% 94.2% 0.0
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.3% 97.4% 0.0

@jerop jerop force-pushed the tep-0090-fanout-runs branch 2 times, most recently from a3bb7d1 to f81d25b Compare June 28, 2022 21:21
@jerop jerop added this to the Pipelines v0.37 milestone Jun 28, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 86.3% 86.2% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.2% 94.2% 0.0
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.3% 97.4% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 86.3% 86.2% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.2% 94.2% 0.0
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.3% 97.4% 0.0

@jerop jerop force-pushed the tep-0090-fanout-runs branch from f81d25b to 3217cee Compare June 28, 2022 21:31
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 86.3% 86.2% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.2% 94.2% 0.0
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.3% 97.4% 0.0

@jerop jerop force-pushed the tep-0090-fanout-runs branch from 3217cee to 31805a0 Compare June 28, 2022 23:44
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 86.3% 86.2% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.2% 94.2% 0.0
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.3% 97.4% 0.0

@jerop jerop force-pushed the tep-0090-fanout-runs branch from 31805a0 to af3563b Compare June 29, 2022 00:56
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 86.3% 86.2% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.2% 94.2% 0.0
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.3% 97.4% 0.0

@jerop
TEP-0090: Fan Out Runs
2c0b0d4 
[TEP-0090: Matrix][tep-0090] proposed executing a `PipelineTask` in
parallel `TaskRuns` and `Runs` with substitutions from combinations
of `Parameters` in a `Matrix`.

This change implements the fan out of `Runs` from a `PipelineTask`
with a `Matrix`. The fanned-out `Runs` are executed in parallel.

[tep-0090]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md
@jerop jerop force-pushed the tep-0090-fanout-runs branch from af3563b to 2c0b0d4 Compare June 29, 2022 12:23
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 86.3% 86.2% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.2% 94.2% 0.0
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 97.3% 97.4% 0.0

@abayer
Copy link
Contributor

abayer commented Jun 29, 2022

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2022
lbernick
lbernick reviewed Jun 29, 2022
View reviewed changes
Copy link
Member

@lbernick lbernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2022
@tekton-robot tekton-robot merged commit 8a3a8e5 into tektoncd:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbernick lbernick lbernick left review comments

@dlorenc dlorenc Awaiting requested review from dlorenc

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.37
Development

Successfully merging this pull request may close these issues.
4 participants
@jerop @tekton-robot @abayer @lbernick