Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for ResourceQuota and QoS #5051

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Update docs for ResourceQuota and QoS #5051

merged 1 commit into from
Jul 7, 2022

Conversation

lbernick
Copy link
Member

Changes

This commit updates compute resources documentation to reflect how Tekton
currently works with ResourceQuotas and how to achieve different levels of
quality of service for Tekton pods.
Closes #4533.

/kind documentation

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • n/a Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels Jun 29, 2022
@tekton-robot tekton-robot requested review from bobcatfish and jerop June 29, 2022 14:21
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 29, 2022
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2022
@lbernick
Copy link
Member Author

/retest

@abayer
Copy link
Contributor

abayer commented Jun 30, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022
@lbernick
Copy link
Member Author

lbernick commented Jul 1, 2022

/test pull-pipeline-kind-k8s-v1-21-e2e

@tekton-robot
Copy link
Collaborator

@lbernick: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-pipeline-kind-k8s-v1-21-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lbernick
Copy link
Member Author

lbernick commented Jul 1, 2022

/retest

@lbernick
Copy link
Member Author

lbernick commented Jul 6, 2022

/test pull-pipeline-kind-k8s-v1-21-e2e

@tekton-robot
Copy link
Collaborator

@lbernick: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage
  • /test pull-tekton-pipeline-kind-alpha-integration-tests
  • /test pull-tekton-pipeline-kind-alpha-yaml-tests
  • /test pull-tekton-pipeline-kind-integration-tests
  • /test pull-tekton-pipeline-kind-yaml-tests

Use /test all to run the following jobs that were automatically triggered:

  • pull-tekton-pipeline-alpha-integration-tests
  • pull-tekton-pipeline-build-tests
  • pull-tekton-pipeline-go-coverage
  • pull-tekton-pipeline-integration-tests
  • pull-tekton-pipeline-unit-tests

In response to this:

/test pull-pipeline-kind-k8s-v1-21-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lbernick
Copy link
Member Author

lbernick commented Jul 6, 2022

/retest

@lbernick
Copy link
Member Author

lbernick commented Jul 7, 2022

/test all

1 similar comment
@lbernick
Copy link
Member Author

lbernick commented Jul 7, 2022

/test all

@abayer
Copy link
Contributor

abayer commented Jul 7, 2022

@lbernick fyi, /test all won't stop kicking off the pull-tekton-pipeline-kind-* jobs for another ~40 minutes, when the cronjob updating the Prow config runs.

@tekton-robot
Copy link
Collaborator

tekton-robot commented Jul 7, 2022 •
edited
Loading

@lbernick: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-pipeline-kind-integration-tests 06afa2f link false /test pull-tekton-pipeline-kind-integration-tests
pull-tekton-pipeline-kind-yaml-tests 06afa2f link false /test pull-tekton-pipeline-kind-yaml-tests
pull-tekton-pipeline-kind-alpha-yaml-tests 06afa2f link false /test pull-tekton-pipeline-kind-alpha-yaml-tests
pull-tekton-pipeline-kind-alpha-integration-tests 06afa2f link false /test pull-tekton-pipeline-kind-alpha-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lbernick
Copy link
Member Author

lbernick commented Jul 7, 2022

fyi, /test all won't stop kicking off the pull-tekton-pipeline-kind-* jobs for another ~40 minutes, when the cronjob updating the Prow config runs.

ah got it thanks Andrew!

@lbernick
Copy link
Member Author

lbernick commented Jul 7, 2022

/test all

@lbernick
Update docs for ResourceQuota and QoS
6656cfe 
This commit updates compute resources documentation to reflect how Tekton
currently works with ResourceQuotas and how to achieve different levels of
quality of service for Tekton pods.
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abayer
Copy link
Contributor

abayer commented Jul 7, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2022
@tekton-robot tekton-robot merged commit d658683 into tektoncd:main Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@jerop jerop Awaiting requested review from jerop

Assignees

@vdemeester vdemeester

@abayer abayer

@skaegi skaegi

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to make a pod to have QoS guaranteed?
6 participants
@lbernick @abayer @tekton-robot @dibyom @vdemeester @skaegi