Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish Pipeline Results from successful TaskRuns in Failed PipelineRuns #5060

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Publish Pipeline Results from successful TaskRuns in Failed PipelineRuns #5060

merged 1 commit into from
Jul 12, 2022

Conversation

QuanZhang-William
Copy link
Member

@QuanZhang-William QuanZhang-William commented Jun 30, 2022 •
edited by pritidesai
Loading

Changes

Publish Pipeline Results from successful TaskRuns in Failed PipelineRuns: #3749

Prior to this change a failed PipelineRun does not emit any PipelineResult even when some PipelineTasks referenced by the PipelineResult succeeded. This commit changes to publish Pipeline Results only from successful PipelineTaskRuns in the failed PipelineRun

Such Results are valid because they are generated by successful TaskRuns. They can provide more context and successful artifacts to users of the partially successful PipelinRun.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

Pipeline results are now initialized even when a pipelineRun fails. The task results from all the successful tasks are propagated to the pipelineRun.

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 30, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 30, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: QuanZhang-William (7190b15)

@tekton-robot tekton-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 30, 2022
@tekton-robot tekton-robot requested review from dlorenc and imjasonh June 30, 2022 14:49
@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 30, 2022
@tekton-robot
Copy link
Collaborator

Hi @QuanZhang-William. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jerop
jerop reviewed Jun 30, 2022
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is solving the first problem only as discussed in the API WG on 06/27:

"Publishing PipelineResults from successful TaskRuns in Failed PipelineRuns"

@QuanZhang-William please update the commit and pull request description to make this clear

@QuanZhang-William QuanZhang-William changed the title publish results on failed pipelinerun Publish Pipeline Results from successful TaskRuns in Failed PipelineRuns Jun 30, 2022
@QuanZhang-William QuanZhang-William force-pushed the 3749-publish-results-on-failed-pipelinerun branch from 7190b15 to 688067f Compare June 30, 2022 15:12
@QuanZhang-William
Copy link
Member Author

/retest

@tekton-robot
Copy link
Collaborator

@QuanZhang-William: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@tekton-robot
Copy link
Collaborator

@QuanZhang-William: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ywluogg
Copy link
Contributor

ywluogg commented Jun 30, 2022

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 30, 2022
@QuanZhang-William QuanZhang-William force-pushed the 3749-publish-results-on-failed-pipelinerun branch from 688067f to 7135f48 Compare June 30, 2022 17:44
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 86.2% 86.3% 0.2

@abayer
Copy link
Contributor

abayer commented Jun 30, 2022

/retest

@QuanZhang-William QuanZhang-William force-pushed the 3749-publish-results-on-failed-pipelinerun branch from 7135f48 to d96d438 Compare July 4, 2022 14:54
@QuanZhang-William
Copy link
Member Author

/retest

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 86.2% 86.3% 0.2

@QuanZhang-William
Copy link
Member Author

/retest

@QuanZhang-William QuanZhang-William marked this pull request as ready for review July 5, 2022 14:14
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 86.2% 86.3% 0.2

@jerop
Copy link
Member

jerop commented Jul 12, 2022

@QuanZhang-William thank you - we need the same information in the commit message too https://github.com/tektoncd/community/blob/main/standards.md#commits

@QuanZhang-William QuanZhang-William force-pushed the 3749-publish-results-on-failed-pipelinerun branch from d96d438 to 532413e Compare July 12, 2022 15:13
@QuanZhang-William
Copy link
Member Author

@QuanZhang-William thank you - we need the same information in the commit message too https://github.com/tektoncd/community/blob/main/standards.md#commits

@QuanZhang-William thank you - we need the same information in the commit message too https://github.com/tektoncd/community/blob/main/standards.md#commits

Oops, updated commit message as well

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 86.2% 86.3% 0.2

@QuanZhang-William QuanZhang-William force-pushed the 3749-publish-results-on-failed-pipelinerun branch from 532413e to 57bdc64 Compare July 12, 2022 15:23
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 86.2% 86.3% 0.2

@lbernick lbernick self-assigned this Jul 12, 2022
@QuanZhang-William
Publish Pipeline Results from successful TaskRuns in Failed PipelineRuns
77ae014 
Prior to this change a failed PipelineRun does not emit any PipelineResult even when some PipelineTasks referenced by the PipelineResult succeeded. This commit changes to publish Pipeline Results only from successful PipelineTaskRuns in the failed PipelineRun

Such Results are valid because they are generated by successful TaskRuns. They can provide more context and successful artifacts to users of the partially successful PipelinRun.
@QuanZhang-William QuanZhang-William force-pushed the 3749-publish-results-on-failed-pipelinerun branch from 57bdc64 to 77ae014 Compare July 12, 2022 19:37
@lbernick
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 86.2% 86.3% 0.2

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 12, 2022
@QuanZhang-William
Copy link
Member Author

/retest

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 86.2% 86.3% 0.2

@tekton-robot tekton-robot merged commit 5126d15 into tektoncd:main Jul 12, 2022
@pritidesai
Copy link
Member

I am very excited for this feature, thank you @QuanZhang-William for implementing this 🙏

@jerop, @lbernick please make sure to have the release notes updated for PRs implementing features. This is a direct user facing change, the users will start seeing pipelineResults even when their pipeline fails. @jerop please make sure to capture this in the 0.38 release notes.

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Jul 13, 2022
@pritidesai
Copy link
Member

I updated the comment in this PR description!

@Yongxuanzhang Yongxuanzhang mentioned this pull request Mar 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbernick lbernick lbernick left review comments

@pritidesai pritidesai pritidesai left review comments

@jerop jerop jerop approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

@imjasonh imjasonh Awaiting requested review from imjasonh

@abayer abayer Awaiting requested review from abayer

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@QuanZhang-William @tekton-robot @ywluogg @abayer @jerop @lbernick @pritidesai