Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0090: Matrix - Consume Results #5063

Merged
merged 1 commit into from
Jul 1, 2022
Merged

TEP-0090: Matrix - Consume Results #5063

merged 1 commit into from
Jul 1, 2022

Conversation

jerop
Copy link
Member

@jerop jerop commented Jun 30, 2022 •
edited
Loading

Changes

TEP-0090: Matrix proposed executing a PipelineTask in parallel TaskRuns and Runs with substitutions from combinations of Parameters in a Matrix.

In this change, we implement consuming Results in a Matrix. This was disallowed in previous iterations of Matrix - validation failed.

With this change, Matrix supports Results of type String. Results of type Array are not yet available at the Pipeline level - this will be handled when it's available.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in (if there are no user facing changes, use release note "NONE")

Release Notes

`Matrix` supports Results of type String.

@tekton-robot tekton-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 30, 2022
@tekton-robot tekton-robot requested review from abayer and imjasonh June 30, 2022 17:10
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 30, 2022
@tekton-robot tekton-robot requested a review from dibyom June 30, 2022 17:10
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2022
@jerop
Copy link
Member Author

jerop commented Jun 30, 2022

cc @abayer @dibyom @lbernick please take a look

@jerop
Copy link
Member Author

jerop commented Jun 30, 2022

/kind feature

/retest

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 30, 2022
@jerop
Copy link
Member Author

jerop commented Jun 30, 2022

/test pull-tekton-pipeline-go-coverage

@tekton-robot
Copy link
Collaborator

@jerop: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test stage-tekton-pipeline-unit-tests

In response to this:

/test pull-tekton-pipeline-go-coverage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/param_types.go 97.9% 97.9% -0.0

@abayer
Copy link
Contributor

abayer commented Jun 30, 2022

/retest

@abayer
Copy link
Contributor

abayer commented Jun 30, 2022

/test pull-tekton-pipeline-go-coverage

@abayer
Copy link
Contributor

abayer commented Jun 30, 2022

/approve

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/param_types.go 97.9% 97.9% -0.0

lbernick
lbernick reviewed Jul 1, 2022
View reviewed changes
docs/matrix.md Outdated Show resolved Hide resolved
pkg/apis/pipeline/v1beta1/param_types.go Show resolved Hide resolved
pkg/reconciler/pipelinerun/pipelinerun_test.go Show resolved Hide resolved
@jerop
Copy link
Member Author

jerop commented Jul 1, 2022

to clarify for reviewers, this change is implementing consuming results in a matrix - https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md#specifying-results-in-the-matrix

producing results from fanned out pipelinetasks is out of scope for tep-0090 (waiting for tep-0075 & tep-0075) - https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md#results-from-fanned-out-pipelinetasks

@jerop
TEP-0090: Matrix - Consume Results
c2c6c86 
[TEP-0090: Matrix][tep-0090] proposed executing a `PipelineTask` in
parallel `TaskRuns` and `Runs` with substitutions from combinations
of `Parameters` in a `Matrix`.

In this change, we implement consuming `Results` in a `Matrix`. This
was disallowed in previous iterations of `Matrix` - validation failed.

With this change, `Matrix` supports Results of type String that are
passed in individually. `Results` of type Array are not yet available
at the `Pipeline` level - this will be handled when it's available.

[tep-0090]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md
@jerop jerop force-pushed the tep-0090-consume-results branch from 002c650 to c2c6c86 Compare July 1, 2022 20:41
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 1, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/param_types.go 97.9% 97.9% -0.0

lbernick
lbernick reviewed Jul 1, 2022
View reviewed changes
Copy link
Member

@lbernick lbernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2022
@jerop
Copy link
Member Author

jerop commented Jul 1, 2022

/test pull-pipeline-kind-k8s-v1-21-e2e

@tekton-robot
Copy link
Collaborator

@jerop: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-pipeline-kind-k8s-v1-21-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerop
Copy link
Member Author

jerop commented Jul 1, 2022

/test pull-tekton-pipeline-alpha-integration-tests

@tekton-robot tekton-robot merged commit c7af1d4 into tektoncd:main Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbernick lbernick lbernick left review comments

@abayer abayer Awaiting requested review from abayer

@imjasonh imjasonh Awaiting requested review from imjasonh

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jerop @tekton-robot @abayer @lbernick