Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for projected volumes as workspace type #5085

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Add support for projected volumes as workspace type #5085

merged 1 commit into from
Jul 21, 2022

Conversation

0xFelix
Copy link
Contributor

@0xFelix 0xFelix commented Jul 6, 2022 •
edited
Loading

Changes

Add support for projected volumes as workspace type

By adding support for projected volumes [1] as workspace type an
arbitrary amount of ConfigMaps or Secrets can be passed to a
TaskRun/PipelineRun without modifying the actual Task/ClusterTask.

This allows to pass data to Tasks/Pipelines in a flexible way.

Fixes #5075

[1] https://kubernetes.io/docs/concepts/storage/projected-volumes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

Add support for projected volumes as workspace type

@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jul 6, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 6, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: 0xFelix / name: Felix Matouschek (83aee34)

@tekton-robot tekton-robot requested review from abayer and pritidesai July 6, 2022 09:23
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 6, 2022
@tekton-robot
Copy link
Collaborator

Hi @0xFelix. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@0xFelix
Copy link
Contributor Author

0xFelix commented Jul 6, 2022

/cc @vdemeester

@tekton-robot tekton-robot requested a review from vdemeester July 6, 2022 09:27
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 6, 2022
@0xFelix 0xFelix mentioned this pull request Jul 7, 2022
Merged
@afrittoli
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 7, 2022
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2022
@piyush-garg
Copy link
Contributor

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 8, 2022
piyush-garg
piyush-garg approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@piyush-garg piyush-garg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good

@dibyom
Copy link
Member

dibyom commented Jul 8, 2022

Should we put this behind an alpha feature flag like we are doing with csi volumes in #5030 ?

@0xFelix
Copy link
Contributor Author

0xFelix commented Jul 11, 2022 •
edited
Loading

I'd argue it does not to be hidden behind a feature flag. It is a combination of existing functionality (Secrets, ConfigMaps) and is provided by K8S itself without any external dependencies. (unlike the CSI drivers in #5030)

@vdemeester
Copy link
Member

I would tend to agree with @0xFelix 👼🏼

@tekton-robot tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 13, 2022
@0xFelix
Copy link
Contributor Author

0xFelix commented Jul 13, 2022

@dibyom What do you think?

@dibyom
Copy link
Member

dibyom commented Jul 15, 2022

@0xFelix @vdemeester I agree that while this is a new field it has fairly well scoped behavior. Where I was coming from was that I thought all new api fields in the beta API had to start behind the alpha feature gate or its own feature flag according to https://github.com/tektoncd/community/blob/main/teps/0033-tekton-feature-gates.md#new-api-fields.

(I did not see this documented in our api policy - maybe we should do that. Or we could also relax our rules to allow for some fields to make it directly into beta without going through an alpha first - what do you think @vdemeester ?)

@vdemeester
Copy link
Member

Given that #5030 has been merged behind the feature-flag, maybe we should do the same. We can refine this a bit later then.

@dibyom
Copy link
Member

dibyom commented Jul 19, 2022

/test tekton-pipeline-unit-tests

@0xFelix
Add support for projected volumes as workspace type
7d06aef 
By adding support for projected volumes [1] as workspace type an
arbitrary amount of ConfigMaps or Secrets can be passed to a
TaskRun/PipelineRun without modifying the actual Task/ClusterTask.

This allows to pass data to Tasks/Pipelines in a flexible way.

Fixes #5075

[1] https://kubernetes.io/docs/concepts/storage/projected-volumes

Signed-off-by: Felix Matouschek <[email protected]>
vdemeester
vdemeester approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link
Collaborator

@vdemeester: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dibyom
Copy link
Member

dibyom commented Jul 20, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2022
@0xFelix
Copy link
Contributor Author

0xFelix commented Jul 21, 2022

/retest

@tekton-robot tekton-robot merged commit fdf682f into tektoncd:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-garg piyush-garg piyush-garg approved these changes

@vdemeester vdemeester vdemeester approved these changes

@abayer abayer Awaiting requested review from abayer

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Projected volumes as workspaces
6 participants
@0xFelix @tekton-robot @afrittoli @piyush-garg @dibyom @vdemeester