-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document leader-election configuration #5104
Conversation
The leader-election config did not describe what the options did and were set to the default values. See https://github.com/knative/pkg/blob/e60d250dc6378c387c8c9d149774ee21e9a827ab/leaderelection/config.go#L121-L127 This commit adds block of commented out example config (like we do in config-defaults). The actual content was taken from https://github.com/knative/serving/blob/f9951ecf37709bb160fd513591e84b6e6f50f6f8/config/core/configmaps/leader-election.yaml
/kind misc |
Are we currently actively using these configuration options, and this PR is replacing them with invalid configuration? Is this documentation code block intended for tekton developers or cluster operators using tekton? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yes, we support a HA mode. The config file was essentially a no-op since it was supplying default values - those values are also present in the code.
This is a configuration with no values specified which means the HA code will use the default config from the code. The docs are mostly intended towards cluster operators. |
/lgtm |
Changes
The leader-election config did not describe what the options did and were set to the default values. See https://github.com/knative/pkg/blob/e60d250dc6378c387c8c9d149774ee21e9a827ab/leaderelection/config.go#L121-L127
This commit adds block of commented out example config (like we do in config-defaults). The actual content was taken from https://github.com/knative/serving/blob/f9951ecf37709bb160fd513591e84b6e6f50f6f8/config/core/configmaps/leader-election.yaml
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes