Move two feature flag related functions to config pkg #5113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/kind cleanup |
tekton-robot
added
do-not-merge/release-note-label-needed
|
/assign @lbernick |
lbernick
approved these changes
Jul 8, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
The following is the coverage report on the affected files.
|
chuangw6
force-pushed
the
move-feature-flag-functions-to-config
branch
2 times, most recently
from
263ba92 to
9168611
Compare
|
The following is the coverage report on the affected files.
|
- getContextBasedOnFeatureFlag - enableAlphaAPIFields Those two feature flag related functions are defined in v1beta1_test packages but used across v1beta1 and v1beta1_test. Since we cannot import v1beta1_test from v1beta1, moving it to the config package will be a solution for it to be used across different packages. Also getContextBasedOnFeatureFlag is overlapping with enableAlphaAPIFields. So it's sufficient to only keep enableAlphaAPIFields.
chuangw6
force-pushed
the
move-feature-flag-functions-to-config
branch
from
9168611 to
df4d68b
Compare
|
The following is the coverage report on the affected files.
|
tekton-robot
added
release-note-none
|
/lgtm |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Those two feature flag related functions are defined in v1beta1_test
packages but used across v1beta1 and v1beta1_test. Since we cannot
import v1beta1_test from v1beta1, moving it to the config package
will be a solution for it to be used across different packages.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes